Re: Some review for the stefan/xo-support branch

[Koen Kooi <k.kooi@student.utwente.nl>]

On 22-10-2008 16:10, Stefan Schmidt wrote:
> Hello.
>
> I just pushed a branch which adds a machine file for the XO, aka OLPC, laptop
> and a kernel recipe for it.
>
> This allows me to build images for the xo machine in Angstrom.
>
> I don't see how these commits could break anything, but as it is my first
> machine I would like to get some review/acks before pushing it into the main
> tree.
>
> Only three commits:
> http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=f5fbcf7e4e0228e10fa2c29f802ea0eaabf7a202
> http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=eff435600359d5f13d846be1480de73e8837133d
> http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=ed58062633bdba98098044e94ffce9207300e4be

One comment:

+PV = "2.6-olpc+git${SRCREV}"

That should be:

2.6.34+gitr${SRCREV}

regards,

Koen