From: Charles Duffy <Charles_Duffy@messageone.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] Fix brown-paper-bag bugs from live-migration patch
Date: Wed, 12 Nov 2008 15:34:39 -0600 [thread overview]
Message-ID: <gffi5g$v3n$1@ger.gmane.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
In TCP migration, prevent an endless loop trying to retrieve error
status. In exec migration, set the close pointer in the FdMigrationState
structure.
Color me embarrassed.
Signed-off-by: Charles Duffy <charles_duffy@messageone.com>
[-- Attachment #2: migration-brown-paper-bag-fixes.patch --]
[-- Type: text/x-patch, Size: 716 bytes --]
diff --git a/migration-exec.c b/migration-exec.c
index 5d0b215..caeed4b 100644
--- a/migration-exec.c
+++ b/migration-exec.c
@@ -85,6 +85,7 @@ MigrationState *exec_start_outgoing_migration(const char *command,
s->opaque = qemu_popen(f, "w");
+ s->close = exec_close;
s->get_error = file_errno;
s->write = file_write;
s->mig_state.cancel = migrate_fd_cancel;
diff --git a/migration-tcp.c b/migration-tcp.c
index 100644b..6fc1943 100644
--- a/migration-tcp.c
+++ b/migration-tcp.c
@@ -32,7 +32,7 @@
static int socket_errno(FdMigrationState *s)
{
- return (s->get_error(s));
+ return socket_error();
}
static int socket_write(FdMigrationState *s, const void * buf, size_t size)
next reply other threads:[~2008-11-12 21:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 21:34 Charles Duffy [this message]
2008-11-12 22:29 ` [Qemu-devel] [PATCH] Fix brown-paper-bag bugs from live-migration patch Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='gffi5g$v3n$1@ger.gmane.org' \
--to=charles_duffy@messageone.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.