Re: E-Ten Glofiish M800 support

[Koen Kooi <k.kooi@student.utwente.nl>]

On 18-11-08 16:59, Stefan Schmidt wrote:
> Hello.
>
> I just pushed a branch with basic machine and kernel support for the M800 from
> E-Ten. Normally Winodws Mobile based device. Linux support is ongoing.
>
> http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=0ea0875a3e5456f701df08e0974821a4e8852f55
>
> As it is just machine, kernel recipe and sane-srcrev it should not break
> anything. Still I would like to ask for review before pushing it in.
>
> How does folks feel about it?

Only some small comments:

conf/machine/eten-m800.conf:
IMAGE_FSTYPES ?= "tar.gz"

change that to += so people don't shoot themselves in the foot too easily

linux-eten_2.6.24+git.bb:
git://git.openmoko.org/git/kernel.git;protocol=git;branch=stable \

Would it make sense to merge this into the openmoko kernel recipe since 
it's building from the same tree? I'm trying to cut down the number of 
linux-foo recipes whenever possible, but it a seperate recipe is easier, 
go for it.

do_configure_prepend() {
   install -m 0644 ${S}/arch/arm/configs/glofiish_defconfig 
${WORKDIR}/defconfig

Please include the defconfig in OE, it's really tedious to have to add 
patches to SRC_URI when changing the defconfig.

Everything else looks good.

regards,

Koen