From: Vladimir Prus <vladimir@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] sh4: Followup to commit #5849 "Change MMIO callbacks..."
Date: Wed, 10 Dec 2008 20:44:26 +0300 [thread overview]
Message-ID: <ghov5q$ev1$1@ger.gmane.org> (raw)
In-Reply-To: 200812031437.mB3EbpeU009295@smtp11.dti.ne.jp
takasi-y@ops.dti.ne.jp wrote:
> Thank you, Paul.
>
>> You should not rely on overlapping regions doing anything sensible.
> OK. fixed.
>
>> Proably simpler to just use a single region for both.
> Ah, that's right. Now the code is very simple (than I have expected).
>
> Here is the patch. Please apply it.
>
> Fixes to be needed for commit #5849 "Change MMIO callbacks..."
> hw/sh7750.c:
> - Divide region of CPU control registers to avoid overlapping
> to peripheral modules.
> - Delete unused var "icr", which had moved to hw/sh_intc.c.
Does sh_intc.c actually handle icr right now? Although I have a local
patch that makes it handle icr0 as well as LVLMODE, I don't see this
patch in SVN HEAD of qemu.
- Volodya
next prev parent reply other threads:[~2008-12-10 17:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 18:59 [Qemu-devel] MMIO address changes Paul Brook
2008-12-02 16:47 ` takasi-y
2008-12-02 17:09 ` Paul Brook
2008-12-02 17:10 ` Paul Brook
2008-12-03 14:37 ` [Qemu-devel] [PATCH] sh4: Followup to commit #5849 "Change MMIO callbacks..." takasi-y
2008-12-10 17:44 ` Vladimir Prus [this message]
2008-12-14 16:54 ` [Qemu-devel] " takasi-y
2008-12-03 12:17 ` [Qemu-devel] MMIO address changes Edgar E. Iglesias
2008-12-03 14:03 ` Paul Brook
2008-12-07 20:24 ` Edgar E. Iglesias
2009-01-07 15:39 ` Edgar E. Iglesias
2008-12-05 13:52 ` [Qemu-devel] [PATCH] usb-ohci: Add address masking takasi-y
2008-12-07 16:05 ` andrzej zaborowski
2008-12-08 13:04 ` Paul Brook
2008-12-08 10:15 ` Thomas Bandelier
2008-12-09 15:21 ` takasi-y
2008-12-11 8:55 ` [Qemu-devel] Re: MMIO address changes Vladimir Prus
2008-12-25 22:33 ` andrzej zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ghov5q$ev1$1@ger.gmane.org' \
--to=vladimir@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.