From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: Re: [RFC] bitbake git fetcher fix
Date: Tue, 06 Jan 2009 18:55:29 +0100 [thread overview]
Message-ID: <gk05ui$6vr$1@ger.gmane.org> (raw)
In-Reply-To: <1231260477.5330.21.camel@dax.rpnet.com>
On 06-01-09 17:47, Richard Purdie wrote:
> On Tue, 2009-01-06 at 16:41 +0100, Koen Kooi wrote:
>> On 06-01-09 15:12, Otavio Salvador wrote:
>>> Hello,
>>>
>>> I've found a issue when using current GIT fetcher and bellow patch
>>> fixes it for me; could someone take a look at it and commit if it does
>>> look fine?
>>> + elif tag and tag != "1":
>> That looks to be a hack for lazy people that don't specify a SRCREV nor
>> set AUTOREV. Such a fetch failure is intended behaviour.
>
> How about we adopt Poky's slightly more verbose approach of SRCREV ?=
> "INVALID" in bitbake.conf?
>
> We check for "INVALID" in bitbake and error if we see it.
I like how it's more "in your face" about it :)
regards,
Koen
next prev parent reply other threads:[~2009-01-06 18:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 14:12 [RFC] bitbake git fetcher fix Otavio Salvador
2009-01-06 15:41 ` Koen Kooi
2009-01-06 16:47 ` Richard Purdie
2009-01-06 17:55 ` Koen Kooi [this message]
2009-01-06 18:25 ` Otavio Salvador
2009-01-06 18:24 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='gk05ui$6vr$1@ger.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
--cc=openembedded-devel@openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.