All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf <rm@amitrader.com>
To: netfilter-devel@vger.kernel.org
Subject: Re: Syntax errors in man and help regarding rulenum placement
Date: Fri, 20 Feb 2009 17:51:30 +0100	[thread overview]
Message-ID: <gnmn2j$mvh$1@ger.gmane.org> (raw)
In-Reply-To: <alpine.LSU.2.00.0902201640001.27281@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> On Friday 2009-02-20 16:12, Ralf wrote:
> 
>> man iptables of v1.4.2 gives these 2 different syntaxes
>> for example for the -I option: 
>> iptables [-t table] -I [rulenum] rule-specification [options...]
>>
>> iptables [-t table] -I chain [rulenum] rule-specification
>>
>>
>> And iptables --help gives these:
>>
>> iptables -[RI] chain rulenum rule-specification [options]
>>
>> --insert  -I chain [rulenum]
>>
>> This is all irritating, don't you think so?
>> Which of them is the officially correct one
>> regarding the placement (location) of the rulenum?
 
Hmm. Jan, I'm afraid there is more to fix because of the fact
that rulenum is mostly optional...
The main question here is: must rulenum come before OR after the chain?


 
> parent 6db2ded2f22a7e78743c86af523b8430876582e9 (v1.4.3-rc1-81-g6db2ded)
> commit 26128f4386b9eb202d9288e7b414cb3ae43819f9
> Author: Jan Engelhardt <jengelh@medozas.de>
> Date:   Fri Feb 20 16:39:54 2009 +0100
> 
> doc: resynchronize manpage with in-code help
> 
> Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
> ---
>  ip6tables.8.in |    6 +++---
>  ip6tables.c    |    3 ++-
>  iptables.8.in  |    6 +++---
>  iptables.c     |    3 ++-
>  4 files changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/ip6tables.8.in b/ip6tables.8.in
> index 3d19a4c..a31887e 100644
> --- a/ip6tables.8.in
> +++ b/ip6tables.8.in
> @@ -30,16 +30,16 @@ ip6tables - IPv6 packet filter administration
>  \fBip6tables\fP [\fB\-t\fP \fItable\fP] {\fB\-A\fP|\fB\-D\fP} \fIchain
>  rule-specification\fP [\fIoptions...\fP]
>  .PP
> -\fBip6tables\fP [\fB\-t\fP \fItable\fP] \fB\-I\fP [\fIrulenum\fP]
> +\fBip6tables\fP [\fB\-t\fP \fItable\fP] \fB\-I\fP \fIchain\fP [\fIrulenum\fP]
>  \fIrule-specification\fP [\fIoptions...\fP]
>  .PP
> -\fBip6tables\fP [\fB\-t\fP \fItable\fP] \fB\-R\fP \fIrulenum
> +\fBip6tables\fP [\fB\-t\fP \fItable\fP] \fB\-R\fP \fIchain rulenum
>  rule-specification\fP [\fIoptions...\fP]
>  .PP
>  \fBip6tables\fP [\fB\-t\fP \fItable\fP] \fB\-D\fP \fIchain rulenum\fP
>  [\fIoptions...\fP]
>  .PP
> -\fBip6tables\fP [\fB\-t\fP \fItable\fP] \fB\-S\fP [\fIchain\fP]
> +\fBip6tables\fP [\fB\-t\fP \fItable\fP] \fB\-S\fP [\fIchain\fP [\fIrulenum\fP]]
>  .PP
>  \fBip6tables\fP [\fB\-t\fP \fItable\fP] {\fB\-F\fP|\fB\-L\fP|\fB\-Z\fP}
>  [\fIchain\fP] [\fIoptions...\fP]
> diff --git a/ip6tables.c b/ip6tables.c
> index 06c0a60..21a0a4e 100644
> --- a/ip6tables.c
> +++ b/ip6tables.c
> @@ -240,7 +240,8 @@ exit_printhelp(struct xtables_rule_match *matches)
>  
>  	printf("%s v%s\n\n"
>  "Usage: %s -[AD] chain rule-specification [options]\n"
> -"       %s -[RI] chain rulenum rule-specification [options]\n"
> +"       %s -I chain [rulenum] rule-specification [options]\n"
> +"       %s -R chain rulenum rule-specification [options]\n"
>  "       %s -D chain rulenum [options]\n"
>  "       %s -[LS] [chain [rulenum]] [options]\n"
>  "       %s -[FZ] [chain] [options]\n"
> diff --git a/iptables.8.in b/iptables.8.in
> index 2bbd9a7..10dcb73 100644
> --- a/iptables.8.in
> +++ b/iptables.8.in
> @@ -27,13 +27,13 @@ iptables - administration tool for IPv4 packet filtering and NAT
>  .SH SYNOPSIS
>  \fBiptables\fP [\fB\-t\fP \fItable\fP] {\fB\-A\fP|\fB\-D\fP} \fIchain\fP \fIrule-specification\fP
>  .PP
> -\fBiptables\fP [\fB\-t\fP \fItable\fP] \fB\-I\fP [\fIrulenum\fP] \fIrule-specification\fP
> +\fBiptables\fP [\fB\-t\fP \fItable\fP] \fB\-I\fP \fIchain\fP [\fIrulenum\fP] \fIrule-specification\fP
>  .PP
> -\fBiptables\fP [\fB\-t\fP \fItable\fP] \fB\-R\fP \fIrulenum rule-specification\fP
> +\fBiptables\fP [\fB\-t\fP \fItable\fP] \fB\-R\fP \fIchain rulenum rule-specification\fP
>  .PP
>  \fBiptables\fP [\fB\-t\fP \fItable\fP] \fB\-D\fP \fIchain rulenum\fP
>  .PP
> -\fBiptables\fP [\fB\-t\fP \fItable\fP] \fB\-S\fP [\fIchain\fP]
> +\fBiptables\fP [\fB\-t\fP \fItable\fP] \fB\-S\fP [\fIchain\fP [\fIrulenum\fP]]
>  .PP
>  \fBiptables\fP [\fB\-t\fP \fItable\fP] {\fB\-F\fP|\fB\-L\fP|\fB\-Z\fP} [\fIchain\fP] [\fIoptions...\fP]
>  .PP
> diff --git a/iptables.c b/iptables.c
> index a8e97c7..56b46b8 100644
> --- a/iptables.c
> +++ b/iptables.c
> @@ -254,7 +254,8 @@ exit_printhelp(struct xtables_rule_match *matches)
>  
>  	printf("%s v%s\n\n"
>  "Usage: %s -[AD] chain rule-specification [options]\n"
> -"       %s -[RI] chain rulenum rule-specification [options]\n"
> +"       %s -I chain [rulenum] rule-specification [options]\n"
> +"       %s -R chain rulenum rule-specification [options]\n"
>  "       %s -D chain rulenum [options]\n"
>  "       %s -[LS] [chain [rulenum]] [options]\n"
>  "       %s -[FZ] [chain] [options]\n"


  reply	other threads:[~2009-02-20 16:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-20 15:12 Syntax errors in man and help regarding rulenum placement Ralf
2009-02-20 15:40 ` Jan Engelhardt
2009-02-20 16:51   ` Ralf [this message]
2009-02-20 16:57     ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='gnmn2j$mvh$1@ger.gmane.org' \
    --to=rm@amitrader.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.