From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: Re: [RFH] Support for automatic package versining using git describe
Date: Thu, 05 Mar 2009 22:37:27 +0100 [thread overview]
Message-ID: <gopgmo$arp$1@ger.gmane.org> (raw)
In-Reply-To: <87sklr3bdy.fsf@ossystems.com.br>
Sorry for top-posting, but I can't find a good point to hook into.
I have a few general questions:
1) what happens when DLDIR and TMPDIR are empty (e.g. first build)
2) does it need a netconnections at any point?
3) do you have any examples how output looks before and after your patch?
I'd also like to hear RPs and zeckes opinion in this
regards,
Koen
On 05-03-09 22:31, Mario Domenech Goulart wrote:
> On Thu, 05 Mar 2009 10:43:04 -0300 Otavio Salvador<otavio@ossystems.com.br> wrote:
>
>> Mario Domenech Goulart<mario@ossystems.com.br> writes:
>>
>>> Index: lib/bb/fetch/git.py
>>> ===================================================================
>>> --- lib/bb/fetch/git.py (revision 1152)
>>> +++ lib/bb/fetch/git.py (working copy)
>>> @@ -42,11 +42,12 @@
>>> ud.proto = ud.parm['protocol']
>>>
>>> ud.branch = ud.parm.get("branch", "master")
>>> + ud.tag = None
>>>
>>> tag = Fetch.srcrev_internal_helper(ud, d)
>>> if tag is True:
>>> ud.tag = self.latest_revision(url, ud, d)
>>> - elif tag:
>>> + elif tag and tag != "1":
>>> ud.tag = tag
>>>
>>> if not ud.tag or ud.tag == "master":
>> [...]
>>
>> Please drop this hook since it is our internal workaround for the lack
>> of the AUTOREV in our recipes.
>
> Sure. Attached is the new patch.
>
> Best wishes.
> Mario
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
next prev parent reply other threads:[~2009-03-05 21:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87iqmp5f58.fsf@neumann.lab.ossystems.com.br>
2009-03-04 18:34 ` [RFH] Support for automatic package versining using git describe Mario Domenech Goulart
2009-03-05 13:43 ` Otavio Salvador
2009-03-05 21:31 ` Mario Domenech Goulart
2009-03-05 21:37 ` Koen Kooi [this message]
2009-03-06 0:50 ` Mike (mwester)
2009-02-13 2:32 Otavio Salvador
2009-02-13 8:59 ` Koen Kooi
2009-02-13 10:46 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='gopgmo$arp$1@ger.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
--cc=openembedded-devel@openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.