From: Jens Scharsig <esw@bus-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch V2] soft_i2c.c compiler/linker error
Date: Mon, 30 Mar 2009 09:51:43 +0200 [thread overview]
Message-ID: <gqptmf$kjd$1@ger.gmane.org> (raw)
In-Reply-To: <gqi9tg$cmf$1@ger.gmane.org>
This patch fix the compiler/linker errors
common/cmd_i2c.c:1252: undefined reference to `i2c_get_bus_speed'
common/cmd_i2c.c:1256: undefined reference to `i2c_set_bus_speed'
if board use CONFIG_I2C_CMD_TREE and CONFIG_I2C_MULTI_BUS is not uesd/undef (wrong define order)
and
removes additional empty lines
Signed-off-by: Jens Scharsig <esw@bus-elektronik.de>
---
diff --git a/drivers/i2c/soft_i2c.c b/drivers/i2c/soft_i2c.c
index ed5f5b2..185634d 100644
--- a/drivers/i2c/soft_i2c.c
+++ b/drivers/i2c/soft_i2c.c
@@ -51,14 +51,12 @@
DECLARE_GLOBAL_DATA_PTR;
#endif
-
/*-----------------------------------------------------------------------
* Definitions
*/
#define RETRIES 0
-
#define I2C_ACK 0 /* PD_SDA level to ack a byte */
#define I2C_NOACK 1 /* PD_SDA level to noack a byte */
@@ -154,7 +152,6 @@ static void send_stop(void)
I2C_TRISTATE;
}
-
/*-----------------------------------------------------------------------
* ack should be I2C_ACK or I2C_NOACK
*/
@@ -174,7 +171,6 @@ static void send_ack(int ack)
I2C_DELAY;
}
-
/*-----------------------------------------------------------------------
* Send 8 bits and look for an acknowledgement.
*/
@@ -246,6 +242,7 @@ int i2c_set_bus_num(unsigned int bus)
#endif
return 0;
}
+#endif
/* TODO: add 100/400k switching */
unsigned int i2c_get_bus_speed(void)
@@ -260,7 +257,6 @@ int i2c_set_bus_speed(unsigned int speed)
return 0;
}
-#endif
/*-----------------------------------------------------------------------
* if ack == I2C_ACK, ACK the byte so can continue reading, else
next prev parent reply other threads:[~2009-03-30 7:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 10:31 [U-Boot] [Patch] soft_i2c.c compiler/linker error Jens Scharsig
2009-03-27 10:46 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-27 11:30 ` Jens Scharsig
2009-03-30 5:22 ` Heiko Schocher
2009-03-30 8:00 ` Jens Scharsig
2009-03-30 5:21 ` Heiko Schocher
2009-03-30 7:51 ` Jens Scharsig [this message]
2009-03-31 6:32 ` [U-Boot] [Patch V2] " Heiko Schocher
2009-03-31 6:18 ` [U-Boot] [Patch V2.1] " Jens Scharsig
2009-03-31 7:08 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='gqptmf$kjd$1@ger.gmane.org' \
--to=esw@bus-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.