From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: Re: [PATCH] add hotplug2 package
Date: Tue, 31 Mar 2009 08:53:24 +0200 [thread overview]
Message-ID: <gqsel4$g9v$1@ger.gmane.org> (raw)
In-Reply-To: <1238452829.7128.4.camel@alap>
On 31-03-09 00:40, Angus Ainslie wrote:
Your commit message is invalid
> +PR = "r0"
r0 is the default so you can remove that
> +DEFAULT_PREFERENCE = "-1"
There's only one version of hotplug2, so why add a default_pref?
> +INITSCRIPT_PARAMS = "start 03 S ."
You forgot to inherit update-rc.d
> +LDFLAGS += "-lglibc"
I don't think that actually works, and if it did, uclibc would break
> +DESTDIR=${D}
missing quotes
> +do_configure () {
> +}
missing colon between the braces. But more importantly: why inherit
autotools when you're not going to run configure?
regards,
Koen
next prev parent reply other threads:[~2009-03-31 6:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 22:40 [PATCH] add hotplug2 package Angus Ainslie
2009-03-31 6:53 ` Koen Kooi [this message]
2009-03-31 15:01 ` Angus Ainslie
2009-03-31 22:14 ` Denys Dmytriyenko
2009-04-01 13:08 ` Angus Ainslie
2009-04-01 13:41 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='gqsel4$g9v$1@ger.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
--cc=openembedded-devel@openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.