All of lore.kernel.org
 help / color / mirror / Atom feed
From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: Re: [PATCH] package.bbclass: fix globbing for mask-like files
Date: Tue, 21 Apr 2009 22:33:30 +0200	[thread overview]
Message-ID: <gslair$mfs$2@ger.gmane.org> (raw)
In-Reply-To: <1238580928-1072-1-git-send-email-khimov@altell.ru>

On 01-04-09 12:15, Roman I Khimov wrote:
> When a package contains two files like "name*" and "name*smth" OE can't
> properly package those, looping infinetely trying to build file list. The
> reason is that first file name globs to two files and OE adds them both
> into the list, then globs the first one again and gets two same files, etc.

Acked-by: Koen Kooi <koen@openembedded.org>


>
> Fix that.
> ---
>   classes/package.bbclass |    8 ++++++--
>   1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/classes/package.bbclass b/classes/package.bbclass
> index 7a61c5a..8a77369 100644
> --- a/classes/package.bbclass
> +++ b/classes/package.bbclass
> @@ -384,8 +384,12 @@ python populate_packages () {
>   			globbed = glob.glob(file)
>   			if globbed:
>   				if [ file ] != globbed:
> -					files += globbed
> -					continue
> +					if not file in globbed:
> +						files += globbed
> +						continue
> +					else:
> +						globbed.remove(file)
> +						files += globbed
>   			if (not os.path.islink(file)) and (not os.path.exists(file)):
>   				continue
>   			if file in seen:





      parent reply	other threads:[~2009-04-21 21:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-01 10:15 [PATCH] package.bbclass: fix globbing for mask-like files Roman I Khimov
2009-04-16 11:52 ` Roman I Khimov
2009-04-21 20:19 ` Roman I Khimov
2009-04-21 20:33 ` Koen Kooi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='gslair$mfs$2@ger.gmane.org' \
    --to=k.kooi@student.utwente.nl \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=openembedded-devel@openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.