All of lore.kernel.org
 help / color / mirror / Atom feed
From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: Re: [PATCH 1/2] tcpdump: fix mix of tabs and spaces in do_configure()
Date: Sat, 30 May 2009 23:15:49 +0200	[thread overview]
Message-ID: <gvs7m5$3ha$4@ger.gmane.org> (raw)
In-Reply-To: <loom.20090530T193103-897@post.gmane.org>

On 30-05-09 21:44, Michael Smith wrote:
> Michael Smith<msmith<at>  cbnco.com>  writes:
>
>> Philip Balister wrote:
>>> It doesn't look like Michael has commit access. I did try applying it,
>>> and git-am said there was a mix of tabs and spaces.
>
>> Yes, the SRC_URI lines were lined up with spaces. It looked nice enough
>> that I didn't fix it;
>
> Hi Philip,
>
> How can I get git am to warn about the mixing? I tried git am
> --whitespace=error-all on the mbox file from patchwork, but it doesn't seem to
> find a mix; actually, in the patch files there are no added lines with spaces,
> only removed lines and a context line.

Ignore git-am "errors" about whitespace. If I add a patch to a recipe 
and do git format-patch in that commit (so you get a patch in a patch) 
git-am will scream bloody murder for something that has no actual 
whitespace errors.
I suspect that the only time you can trust git output is when your name 
is Linus and work on kernel code.

regards,

Koen




  reply	other threads:[~2009-05-30 21:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-28 18:23 [PATCH 1/2] tcpdump: fix mix of tabs and spaces in do_configure() Michael Smith
2009-05-28 18:23 ` [PATCH 2/2] tcpdump 4.0.0-r2: remove extra ${sbindir}/tcpdump.4.0.0 Michael Smith
2009-05-28 19:36 ` [PATCH 1/2] tcpdump: fix mix of tabs and spaces in do_configure() Denys Dmytriyenko
2009-05-28 20:21   ` Philip Balister
2009-05-28 20:35     ` Michael Smith
2009-05-30 19:44       ` Michael Smith
2009-05-30 21:15         ` Koen Kooi [this message]
2009-05-30 22:21           ` Otavio Salvador
2009-06-07 20:49     ` [PATCH] tcpdump: fix mix of tabs and spaces Michael Smith
2009-06-07 20:49       ` [PATCH] tcpdump 4.0.0-r2: remove extra ${sbindir}/tcpdump.4.0.0 Michael Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='gvs7m5$3ha$4@ger.gmane.org' \
    --to=k.kooi@student.utwente.nl \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=openembedded-devel@openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.