Re: Patch for libfann-2.0.0 recipe

[Koen Kooi <k.kooi@student.utwente.nl>]

On 18-06-09 20:09, Philip Balister wrote:
> Koen Kooi wrote:
>> On 18-06-09 18:05, Elvis Dowson wrote:
>>> Hi Rolf,
>>>
>>> On Jun 17, 2009, at 8:43 AM, Rolf Leggewie wrote:
>>>
>>>> Can you please take a look at
>>>> http://wiki.openembedded.net/index.php/Styleguide and reorder the
>>>> fields accordingly? I think there is also a script in the contrib
>>>> directory to help with this.
>>>
>>> Here is the modified recipe: recipes/libfann/libfann-2.0.0.bb
>>>
>>> DESCRIPTION = "Fast Artificial Neural Network Library"
>>> HOMEPAGE = "http://leenissen.dk/fann/"
>>> SECTION = "libs"
>>> LICENSE = "BSD"
>>> SRCDATE = "20090618"
>>> PV = "2.0.0"
>>
>>> PR = "r01"
>>
>> Don't set PR to that.
>>
>>> SRC_URI = "http://prdownloads.sourceforge.net/fann/fann-${PV}.tar.bz2"
>>>
>>> S = "${WORKDIR}/fann-${PV}"
>>>
>>> inherit autotools pkgconfig
>>
>> use AUTOTOOLS_STAGE_PKGCONFIG = "1"
>>
>>> do_stage () {
>>> oe_libinstall -a -so -C src libfann ${STAGING_LIBDIR}
>>> install -d ${STAGING_INCDIR}/fann
>>> (cd ${S}/src/include; cp compat_time.h config.h doublefann.h fann.h
>>> fann_activation.h fann_cascade.h fann_data.h fann_error.h
>>> fann_internal.h fann_io.h fann_train.h fixedfann.h floatfann.h
>>> ${STAGING_INCDIR}/fann/)
>>> install -m 0644 ${S}/aclocal.m4 ${STAGING_DATADIR}/aclocal/
>>> }
>>
>> Again, don't use custom staging methods for silly reasons.
>
> I don't think the reason here is silly. I checked on my Fedora box and
> it installs the headers in include/fann/*.h also. The headers may need
> installing here so we can avoid patching existing software. I'm not
> intimately familiar with fann, so it would be great if people who are
> could look at this.

I think the fann authors know best where to install their to, which 
means using autotools_stage_all.

regards,

Koen