From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] armv5te mentioned twice on eabi-capable list
Date: Wed, 16 Sep 2009 20:17:48 +0200 [thread overview]
Message-ID: <h8ra4c$o1k$1@ger.gmane.org> (raw)
In-Reply-To: <f96d234e0909160548r3ec9a8c8r2c27c29910203401@mail.gmail.com>
On 16-09-09 14:48, Cliff Brake wrote:
> On Wed, Sep 16, 2009 at 6:19 AM, Aleksandr Koltsoff<czr@iki.fi> wrote:
>> (My first patch generated with git, please be gentle :-).
>>
>> armv5te is mentioned twice in the arm_eabi_supporting_arches list of
>> sane-toolchain.inc. Remove the latter occurance.
>
> Looks good. I'll let Khem or some who is more familiar with toolchains apply.
>
> One suggestion, we have a commit policy
> (http://wiki.openembedded.net/index.php/Commit_Policy), so if you
> follow that on future patches, we can directly git-am your patches and
> push them with no extra work.
>
> So the commit message for this might be:
>
> sane-toolchain.inc: remove extra armv5te in eabi-capable list
>
> This allows people to very quickly get an idea what this patch applies
> to, and makes for nice formatting in the weekly change logs.
Note that in general we don't like putting the filename in the commit
message.
regards,
Koen
next prev parent reply other threads:[~2009-09-16 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 10:19 [PATCH] armv5te mentioned twice on eabi-capable list Aleksandr Koltsoff
2009-09-16 12:48 ` Cliff Brake
2009-09-16 18:17 ` Koen Kooi [this message]
2009-09-17 0:55 ` Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='h8ra4c$o1k$1@ger.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.