From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lo.gmane.org ([80.91.229.12]) by linuxtogo.org with esmtp (Exim 4.69) (envelope-from ) id 1NBRug-0001Bw-C1 for openembedded-devel@lists.openembedded.org; Fri, 20 Nov 2009 12:44:33 +0100 Received: from list by lo.gmane.org with local (Exim 4.50) id 1NBRtK-0003G5-Kt for openembedded-devel@lists.openembedded.org; Fri, 20 Nov 2009 12:43:06 +0100 Received: from s55917625.adsl.wanadoo.nl ([85.145.118.37]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Nov 2009 12:43:06 +0100 Received: from k.kooi by s55917625.adsl.wanadoo.nl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 20 Nov 2009 12:43:06 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: openembedded-devel@lists.openembedded.org From: Koen Kooi Date: Fri, 20 Nov 2009 12:42:43 +0100 Message-ID: References: <4B067785.50600@SSpaeth.de> Mime-Version: 1.0 X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: s55917625.adsl.wanadoo.nl User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.6pre) Gecko/20091109 Shredder/3.0pre In-Reply-To: <4B067785.50600@SSpaeth.de> Sender: news X-SA-Exim-Connect-IP: 80.91.229.12 X-SA-Exim-Mail-From: gcho-openembedded-devel@m.gmane.org X-SA-Exim-Version: 4.2.1 (built Wed, 25 Jun 2008 17:20:07 +0000) X-SA-Exim-Scanned: No (on linuxtogo.org); Unknown failure Subject: Re: [Fwd: [Shr-Devel] [PATCH] ILLUME_CONFIG is now also set by a variable] X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Nov 2009 11:44:33 -0000 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20-11-09 12:03, Sebastian Spaeth wrote: > See attached patch. We'd love to replace the default illume config with > our distro-specific version, so this will make the config RDEPENDS > overridable from our distro conf. Is such a change acceptable for OE? The change looks file, but the Author field is wrong (people have last names, unless you're called Wookie) and the commit message isn't to OE standards either. In the future fix up both before committing. It can get tedious, I know, I do it for my coworkers as well :) regards, Koen