Re: RFC: Sane default for SPLASH

[Rolf Leggewie <no2spam@nospam.arcornews.de>]

[-- Attachment #1: Type: text/plain, Size: 805 bytes --]

Koen Kooi wrote:
> NAK, the needless SPLASH -> BOOTSPLASH will create too much work for
> people to catch up to, and it messes up the docs on the subject.

With respect to "needless", the reasons for the change were given in
this thread.  Please revisit the discussion.

And in any case, the tremendous (LOL) amount of work can be
significantly reduced with the help of sed, as I'm sure you are aware.

With regard to docs:

$ rgrep SPLASH docs/
$

The wiki has nothing on it, either.  Nothing but hot air?

This has become a non-core change, I don't feel bound by your NAK. That
being said, I know of your tendency of "my way or the highway" and have
prepared a new patch that omits the name change but is otherwise
identical.  Since this addresses your "concerns" I await your ACK.

[-- Attachment #2: bootsplash.patch --]
[-- Type: text/x-patch, Size: 1691 bytes --]

diff --git a/classes/image.bbclass b/classes/image.bbclass
index ab58031..9dce609 100644
--- a/classes/image.bbclass
+++ b/classes/image.bbclass
@@ -17,6 +17,9 @@ IMAGE_INITSCRIPTS ?= "initscripts"
 #
 IMAGE_LOGIN_MANAGER ?= "tinylogin"
 
+# set sane default for the SPLASH variable
+SPLASH ?= ""
+
 IMAGE_KEEPROOTFS ?= ""
 IMAGE_KEEPROOTFS[doc] = "Set to non-empty to keep ${IMAGE_ROOTFS} around after image creation."
 
diff --git a/recipes/images/console-base-image.bb b/recipes/images/console-base-image.bb
index d25a4fc..9bd5031 100644
--- a/recipes/images/console-base-image.bb
+++ b/recipes/images/console-base-image.bb
@@ -4,7 +4,6 @@ IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
 
 ANGSTROM_EXTRA_INSTALL ?= ""
 
-SPLASH ?= ""
 ZZAPSPLASH = ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-zap", "",d)}'
 
 DEPENDS = "task-base \
diff --git a/recipes/images/gnuradio-image.bb b/recipes/images/gnuradio-image.bb
index 53e79b8..6bccda0 100644
--- a/recipes/images/gnuradio-image.bb
+++ b/recipes/images/gnuradio-image.bb
@@ -4,7 +4,6 @@ IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
 
 IMAGE_EXTRA_INSTALL ?= ""
 
-SPLASH ?= ""
 ZZAPSPLASH = ' ${@base_contains("MACHINE_FEATURES", "screen", "psplash-zap", "",d)}'
 
 DEPENDS = "task-base-extended \
diff --git a/recipes/images/minimal-image.bb b/recipes/images/minimal-image.bb
index e9abcb3..0bd8019 100644
--- a/recipes/images/minimal-image.bb
+++ b/recipes/images/minimal-image.bb
@@ -4,8 +4,6 @@
 ANGSTROM_EXTRA_INSTALL ?= ""
 DISTRO_SSH_DAEMON ?= "dropbear"
 
-SPLASH ?= " "
-
 IMAGE_PREPROCESS_COMMAND = "create_etc_timestamp"
 
 IMAGE_INSTALL = "task-boot \