From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lo.gmane.org ([80.91.229.12]) by linuxtogo.org with esmtp (Exim 4.69) (envelope-from ) id 1NYkKV-0003bU-Jl for openembedded-devel@lists.openembedded.org; Sat, 23 Jan 2010 19:03:30 +0100 Received: from list by lo.gmane.org with local (Exim 4.50) id 1NYkIB-0003Ae-VY for openembedded-devel@lists.openembedded.org; Sat, 23 Jan 2010 19:01:03 +0100 Received: from s55917625.adsl.wanadoo.nl ([85.145.118.37]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 23 Jan 2010 19:01:03 +0100 Received: from k.kooi by s55917625.adsl.wanadoo.nl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 23 Jan 2010 19:01:03 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: openembedded-devel@lists.openembedded.org From: Koen Kooi Date: Sat, 23 Jan 2010 19:00:42 +0100 Message-ID: References: <201001230943.24210.holger+oe@freyther.de> <1264249142.3630.41.camel@mattotaupa.wohnung.familie-menzel.net> <1264263068.9974.14.camel@lenovo.internal.reciva.com> Mime-Version: 1.0 X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: s55917625.adsl.wanadoo.nl User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.7) Gecko/20100113 Shredder/3.0.2pre In-Reply-To: <1264263068.9974.14.camel@lenovo.internal.reciva.com> X-Enigmail-Version: 1.0 Sender: news X-SA-Exim-Connect-IP: 80.91.229.12 X-SA-Exim-Mail-From: gcho-openembedded-devel@m.gmane.org X-SA-Exim-Version: 4.2.1 (built Wed, 25 Jun 2008 17:20:07 +0000) X-SA-Exim-Scanned: No (on linuxtogo.org); Unknown failure Subject: Re: New state for patches not complying with commit policy X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jan 2010 18:03:30 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 23-01-10 17:11, Phil Blundell wrote: > On Sat, 2010-01-23 at 13:19 +0100, Paul Menzel wrote: >> If it is possible, I suggest to add a new state (»Rejected – Commit >> Policy«) for patches not complying with the commit policy [3]? > > If the patch is basically correct then it seems a little bit officious > to reject it purely because it fails to conform to the commit policy in > some way. Most of the issues listed in the policy are easy enough to > fix up when applying the patch, after all. And yet OE developers aren't fixing those up (latest example: the patch stack Khem pushed last week), however easy it may be. Maybe it's a case of sampling bias since I only inspect bad commits, but in any case, the commit message of the commits that end up in .dev needs to get improved. regards, Koen -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFLWzlJMkyGM64RGpERAvyDAKCE7pBD3krfl2wBN4GvYi59Wi+g8wCeLNmA Wg9qotVtOlkyOtLgSkhTrPQ= =ar+b -----END PGP SIGNATURE-----