Re: [patch] video/et61x251: improve error handling

["Christophe JAILLET" <christophe.jaillet@wanadoo.fr>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]

Hi,

this patch seems incomplet.

You had an opening { whitout the corresponding }.

Best regards,
Christophe Jaillet

"Dan Carpenter" <error27@gmail.com> a écrit
dans le message de news:20100328114945.GV5069@bicker...
> The original code doesn't handle the situation where the controller is
> not found.
>
> Signed-off-by: Dan Carpenter
<error27@gmail.com>
>
> diff --git a/drivers/media/video/et61x251/et61x251_core.c
b/drivers/media/video/et61x251/et61x251_core.c
> index e6c23d5..a5cfc76 100644
> --- a/drivers/media/video/et61x251/et61x251_core.c
> +++ b/drivers/media/video/et61x251/et61x251_core.c
> @@ -1713,7 +1713,7 @@ et61x251_vidioc_s_ctrl(struct et61x251_device* cam,
void __user * arg)
>   if (copy_from_user(&ctrl, arg, sizeof(ctrl)))
>   return -EFAULT;
>
> - for (i = 0; i < ARRAY_SIZE(s->qctrl); i++)
> + for (i = 0; i < ARRAY_SIZE(s->qctrl); i++) {
>   if (ctrl.id == s->qctrl[i].id) {
>   if (s->qctrl[i].flags & V4L2_CTRL_FLAG_DISABLED)
>   return -EINVAL;
> @@ -1723,7 +1723,9 @@ et61x251_vidioc_s_ctrl(struct et61x251_device* cam,
void __user * arg)
>   ctrl.value -= ctrl.value % s->qctrl[i].step;
>   break;
>   }