Re: [PATCH 1/1] distribute_license: added class to copy license files

[Koen Kooi <k.kooi@student.utwente.nl>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 29-07-10 22:55, Bernhard Reutner-Fischer wrote:
> On Thu, Jul 29, 2010 at 09:51:01AM -0500, Chase Maupin wrote:
>> * This class can be used to copy license files from package
>>  sources into the deploy directory so they can be distributed.
>> * By default it searches the top-level source directory for
>>  files matching COPYING* or LICENSE*
>> * Search depth and pattern can be modified using the
>>  LICENSE_SEARCH_DEPTH and LICENSE_FILES variables
>>  respectively.
>>
>> Signed-off-by: Chase Maupin <chase.maupin@ti.com>
>> ---
>> classes/distribute_license.bbclass |   56 ++++++++++++++++++++++++++++++++++++
>> 1 files changed, 56 insertions(+), 0 deletions(-)
>> create mode 100644 classes/distribute_license.bbclass
>>
>> diff --git a/classes/distribute_license.bbclass b/classes/distribute_license.bbclass
>> new file mode 100644
>> index 0000000..795a404
>> --- /dev/null
>> +++ b/classes/distribute_license.bbclass
>> @@ -0,0 +1,56 @@
>> +# distribute-license.bbclass will search the sources of a package to
>> +# a given depth looking for a match to the specified pattern and if
>> +# found will copy the matching file(s) to the deploy directory.
>> +#
>> +# This class is used to collect license files such as COPYING or
>> +# LICENSE where they are found and save them per package.
>> +#
>> +# This package uses the following variables to control its operations:
>> +#   - LICENSE_FILES         = Pattern of license files to be searched for.
>> +#                             By default this is COPYING* and LICENSE* but
>> +#                             this can be changed per package.
>> +#   - LICENSE_SEARCH_DEPTH  = The maximum depth to search in the package
>> +#                             sources for files matching the LICENSE_FILES
>> +#                             pattern.
>> +
>> +
>> +# Files to copy for the licensing.  By default this is looking for
>> +# files following the patters COPYING* or LICENSING* in the top
>> +# level sources directory.
>> +LICENSE_FILES ?= "COPYING* LICENSE*"
>> +
>> +# Maximum depth to look for license files
>> +LICENSE_SEARCH_DEPTH ?= "1"
>> +
>> +distribute_license_do_copy_license() {
>> +    # Change directory to source directory
>> +    cd ${S}
>> +
>> +    # Turn of globbing so that wildcards are not expanded in for loop
> 
> /s/of/off/
> 
>> +    set -f
> 
> hush: set: -f: invalid option

I don't think we realistically support something different than bash.
Having said that, adding hashisms is bad, do you have a suggestion for a
more portable approach?

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMUnWrMkyGM64RGpERAi/2AKCGmm0kgEu54YytOloQwn5r54WH/ACfbw2+
4wUfIALobrMrVMin2tcloyU=
=wG8e
-----END PGP SIGNATURE-----