All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Ebert <info@ralfebert.de>
To: git@vger.kernel.org
Subject: Re: [PATCH] More readable 'Not a git repository' messages
Date: Tue, 10 Aug 2010 01:34:41 +0200	[thread overview]
Message-ID: <i3q3ah$upb$1@dough.gmane.org> (raw)
In-Reply-To: <20100809230132.GG4429@burratino>

Hi Jonathan,

> I hope not, since then the returned cwd value would be useless
> for restoring the original cwd later.

yes, right, I misread the code, thanks for taking the time to correct 
me. My C knowledge is dated to say least and being succumbed by all the 
syntax sugar of dynamic languages, I misread
if (chdir("..")) { ... }
as "if changing the directory worked ok" :)

> Shameless plug: you may find the version in commit 98937be (i.e.
> branch jn/maint-setup-fix in pu) more readable. :)

I do, I guess it makes sense to rework the patch on top of that.

What I also wanted to try is make the GIT_DISCOVERY_ACROSS_FILESYSTEM 
warning go away for crypto home volumes, because that's kind of common 
and nobody needs git to discover repositories in this case. Only need to 
come up with an idea how to detect this case.

--
Ralf

  reply	other threads:[~2010-08-09 23:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-09 17:24 [PATCH] More readable 'Not a git repository' messages Ralf Ebert
2010-08-09 22:14 ` Nguyen Thai Ngoc Duy
2010-08-09 22:44   ` Ralf Ebert
2010-08-09 23:01     ` Jonathan Nieder
2010-08-09 23:34       ` Ralf Ebert [this message]
2010-08-10 11:31         ` Nguyen Thai Ngoc Duy
2010-08-10  2:49 ` Sverre Rabbelier
2010-08-10 15:52 ` Jared Hance
2010-08-10 22:34   ` Joshua Juran
2010-08-13 17:25 ` [PATCH/RFC v2] " Ralf Ebert
2010-08-13 17:30   ` Joshua Juran
2010-08-15  2:55   ` [PATCH] setup.c: Improve " Ralf Ebert
2010-08-15  3:36     ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='i3q3ah$upb$1@dough.gmane.org' \
    --to=info@ralfebert.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.