Re: linux-omap-psp-2.6.32 breaks iscsi-target

[Koen Kooi <k.kooi@student.utwente.nl>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 30-08-10 19:47, Frans Meulenbroeks wrote:
> The current beagleboard angstrom and minimal distro's (and maybe
> others) use the linux-omap-psp_2.6.32.bb recipe to build the kernel.
> 
> This one says:
> # This is the v2.6.32_OMAPPSP_03.00.01.06 branch
> SRCREV = "a6bad4464f985fdd3bed72e1b82dcbfc004d7869"
> 
> # The main PR is now using MACHINE_KERNEL_PR, for omap3 see
> conf/machine/include/omap3.inc
> MACHINE_KERNEL_PR_append = "+gitr${SRCREV}"
> 
> SRC_URI = "git://arago-project.org/git/people/sriram/ti-psp-omap.git;protocol=git;branch=master
> \
> 
> Building it creates:
> linux-omap-psp-2.6.32-r88+gitra6bad4464f985fdd3bed72e1b82dcbfc004d7869
> 
> However this is not a sound 2.6.32 tree. It contains this patch
> http://arago-project.org/git/people/?p=sriram/ti-psp-omap.git;a=commit;h=c720c7e8383aff1cb219bddf474ed89d850336e3
> which was not in the mainstream kernel in 2.6.32

What a surprise, a vendor kernel has patches that aren't in mainline linux!

> (compare
> http://arago-project.org/git/people/?p=sriram/ti-psp-omap.git;a=blob;f=include/net/inet_sock.h;hb=c720c7e8383aff1cb219bddf474ed89d850336e3
> with
> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.32.y.git;a=blob;f=include/net/inet_sock.h;h=47004f35cc7eaf6f2b3cac2779ea7b7ccd5d9c1f;hb=HEAD
> ).
> 
> The patch mentioned above was integrated in a 2.6.33 rc version.
> 
> iscsi-utils uses the inet_sock struct, and contains code to access the
> daddr field of this struct. For versions <= .32 daddr is used. for
> higher versions inet_daddr is used.
> However the omap-psp kernel from arago does contain this patch  but
> reports as a .32 kernel causing a compiler errir when compiling
> iscsi_target (as the name the recipe expects is not there).
> 
> Not sure how to fix it. Changing the test in iscsi-target is not an
> option as then it does not work for official .32 kernels.
> Probably the best way to fix this is to use the above patch to revert
> the change.
> 
> anyone a better solution?

I can tell you right now that patching the psp kernel will not be
accepted, so patching the iscsi recipe is the way to go.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMfL2iMkyGM64RGpERAnaBAJ4glYrqGU/BeU7lh2TjOzBwkXF8ewCeNqyI
4wpc1emvnlEv5xsgE6HhqLY=
=H4DQ
-----END PGP SIGNATURE-----