From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] insane.bbclass: Enable the insane.bbclass for everyone in a warning mode
Date: Sun, 12 Sep 2010 13:50:30 +0200 [thread overview]
Message-ID: <i6ieq6$sld$2@dough.gmane.org> (raw)
In-Reply-To: <4C8CA2DC.40707@freyther.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12-09-10 11:52, Holger Freyther wrote:
>
> Make conf/bitbake.conf load conf/insane.conf that will INHERIT the
> insane.bbclass. Remove the INHERIT from the distros currently using
> insane.bbclass. Change insane.bbclass to check QA_FATAL to see if errors
> are allowed to be fatal, make SHR/Kaelios and Angstrom use that new
> flag to continue having fatal QA Errors.
>
> Signed-off-by: Holger Hans Peter Freyther <zecke@selfish.org>
Looks good to me, but a slight nit-pick:
+#log QA errors
QA_LOG = "1"
+QA_FATAL = "1"
Can you change the comment to something like:
# Log QA errors and abort the build when encountering them
So that it's clear what the 2 vars do?
regards,
Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFMjL6GMkyGM64RGpERAu6nAJ9YVJtjYLE4RJGT8vJaFtCUUpNHLwCfQUXn
bWPfFuQSJMkJMmjkg1j7gAY=
=Chyt
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2010-09-12 11:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-12 9:52 [PATCH] insane.bbclass: Enable the insane.bbclass for everyone in a warning mode Holger Freyther
2010-09-12 11:50 ` Koen Kooi [this message]
2010-09-12 14:06 ` Holger Freyther
2010-09-12 18:50 ` Koen Kooi
2010-09-12 12:32 ` Frans Meulenbroeks
2010-09-12 12:38 ` Leon Woestenberg
2010-09-12 15:00 ` Holger Freyther
2010-09-12 15:06 ` Chris Larson
2010-09-13 6:35 ` Frans Meulenbroeks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='i6ieq6$sld$2@dough.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.