From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lo.gmane.org ([80.91.229.12]) by linuxtogo.org with esmtp (Exim 4.69) (envelope-from ) id 1Oul9z-0007Eu-7I for openembedded-devel@lists.openembedded.org; Sun, 12 Sep 2010 13:55:51 +0200 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Oul9E-0007Bk-8E for openembedded-devel@lists.openembedded.org; Sun, 12 Sep 2010 13:55:04 +0200 Received: from s55917625.adsl.wanadoo.nl ([85.145.118.37]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 12 Sep 2010 13:55:04 +0200 Received: from k.kooi by s55917625.adsl.wanadoo.nl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 12 Sep 2010 13:55:04 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: openembedded-devel@lists.openembedded.org From: Koen Kooi Date: Sun, 12 Sep 2010 13:50:30 +0200 Message-ID: References: <4C8CA2DC.40707@freyther.de> Mime-Version: 1.0 X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: s55917625.adsl.wanadoo.nl User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.11) Gecko/20100729 Shredder/3.0.7pre In-Reply-To: <4C8CA2DC.40707@freyther.de> X-Enigmail-Version: 1.0.1 X-SA-Exim-Connect-IP: 80.91.229.12 X-SA-Exim-Mail-From: gcho-openembedded-devel@m.gmane.org X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on discovery X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.2.5 X-SA-Exim-Version: 4.2.1 (built Wed, 25 Jun 2008 17:20:07 +0000) X-SA-Exim-Scanned: Yes (on linuxtogo.org) Subject: Re: [PATCH] insane.bbclass: Enable the insane.bbclass for everyone in a warning mode X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2010 11:55:51 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12-09-10 11:52, Holger Freyther wrote: > > Make conf/bitbake.conf load conf/insane.conf that will INHERIT the > insane.bbclass. Remove the INHERIT from the distros currently using > insane.bbclass. Change insane.bbclass to check QA_FATAL to see if errors > are allowed to be fatal, make SHR/Kaelios and Angstrom use that new > flag to continue having fatal QA Errors. > > Signed-off-by: Holger Hans Peter Freyther Looks good to me, but a slight nit-pick: +#log QA errors QA_LOG = "1" +QA_FATAL = "1" Can you change the comment to something like: # Log QA errors and abort the build when encountering them So that it's clear what the 2 vars do? regards, Koen -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFMjL6GMkyGM64RGpERAu6nAJ9YVJtjYLE4RJGT8vJaFtCUUpNHLwCfQUXn bWPfFuQSJMkJMmjkg1j7gAY= =Chyt -----END PGP SIGNATURE-----