Re: [PATCH] at91bootstrap.inc: Mark COMPATIBLE_MACHINEs.

[Koen Kooi <k.kooi@student.utwente.nl>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

As a general remark to your current patch series, I think there is some
confusion what COMPATIBLE_MACHINE is for. To me it's signals "this
recipe is specific to a *machine*", not "this recipe is missing files to
make it work without other archs/machines".

The cases:

spidermonkey/firefox/numpy: needs jsautocfg.h for each arch, no need for
COMPATIBLE_MACHINE or COMPATIBLE_ARCH, people need to add support for
their archs

u-boot-env/pivotboot: needs a file for each machine to work properly,
but adding an (empty) fallback file is the way to go since it's only
used in deploy/.

Tacking on COMPATIBLE_{MACHINE,HOST} would just hide the problems and
make fixing it more more tedious than it needs to be. For kernel and
uboot C_M is used to make bitbake do the right thing since they all
share the same PN.

That's my take on the situation, dunno if it's the consensus or not.

regards,

Koen

On 22-09-10 02:41, Graham Gower wrote:
> From b90a9fef712cc934863ee786b2d2dedc37d6902d Mon Sep 17 00:00:00 2001
> From: Graham Gower <graham.gower@gmail.com>
> Date: Wed, 22 Sep 2010 09:39:00 +0930
> Subject: [PATCH 1/5] at91bootstrap.inc: Mark COMPATIBLE_MACHINEs.
> 
> 
> Signed-off-by: Graham Gower <graham.gower@gmail.com>
> ---
>  recipes/at91bootstrap/at91bootstrap.inc |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/recipes/at91bootstrap/at91bootstrap.inc b/recipes/at91bootstrap/at91bootstrap.inc
> index 2160f64..dfe143a 100644
> --- a/recipes/at91bootstrap/at91bootstrap.inc
> +++ b/recipes/at91bootstrap/at91bootstrap.inc
> @@ -1,6 +1,7 @@
>  DESCRIPTION = "at91bootstrap: loaded into internal SRAM by AT91 BootROM"
>  SECTION = "bootloaders"
>  
> +COMPATIBLE_MACHINE = "(afeb9260|at91cap9adk|at91sam9g20ek|at91sam9rlek|at91sam9263ek|at91sam9260ek|at91sam9xeek|at91sam9261ek)"
>  SRC_URI = "ftp://www.at91.com/pub/buildroot/${PN}-${PV}.tar.bz2 \
>  	   file://defconfig \
>             "

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMmlSbMkyGM64RGpERAtR1AKChk2g0bwBLsiyDaAsw94CZsWt9fwCfRw0L
bkqI5S6ortqh1+QHpHVQm1s=
=re7X
-----END PGP SIGNATURE-----