From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCHv3 1/3] kernel bbclass: split do_compile into do_compile and do_compile_modules
Date: Tue, 12 Oct 2010 12:34:40 +0200 [thread overview]
Message-ID: <i91dk0$7lv$1@dough.gmane.org> (raw)
In-Reply-To: <AANLkTimnE3nuhgQQpCrZ0ymjzmLUkK0wxNX8bqJwa=AF@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12-10-10 12:08, Frans Meulenbroeks wrote:
> 2010/10/12 Koen Kooi <k.kooi@student.utwente.nl>:
>>> +}
>>> +
>>> +do_compile_kernelmodules() {
>>> + unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE
>
> Is it needed/required?
It is, and it's in kernel.bbclass already:
fe938bbe (Michael Lauer 2004-12-14) kernel_do_compile() {
0448ec0d (Richard Purdie 2006-11-20) unset CFLAGS CPPFLAGS CXXFLAGS
LDFLAGS MACHINE
fe938bbe (Michael Lauer 2004-12-14) oe_runmake
include/linux/version.h CC="${KERNEL_CC}" LD="${KERNEL_LD}"
> I'm a little bit concerned by this.
> (actually this was the only worry I had after reading the patch, don't
> want to loose additional CFLAGS settings here
You actually want to do that, since the kernel is bare-metal, not userspace.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFMtDm/MkyGM64RGpERAuFwAKCBzAXJwVvcQ6oh2DSISA/7Hhh8zACgp9M9
muqzjUd8tGg/RCZoEKmsU/4=
=1SOi
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2010-10-12 10:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 7:55 [PATCHv3 1/3] kernel bbclass: split do_compile into do_compile and do_compile_modules Koen Kooi
2010-10-11 7:55 ` [PATCHv3 2/3] kernel bbclass: make 'kernel-modules' meta-package use RRECOMMENDS to please insane.bbclass Koen Kooi
2010-10-12 12:55 ` Frans Meulenbroeks
2010-10-11 7:55 ` [PATCHv3 3/3] multi-kernel: adapt to kernel_do_compile_kernelmodules change in kernel.bbclass Koen Kooi
2010-10-12 12:54 ` Frans Meulenbroeks
2010-10-12 8:09 ` [PATCHv3 1/3] kernel bbclass: split do_compile into do_compile and do_compile_modules Koen Kooi
2010-10-12 10:08 ` Frans Meulenbroeks
2010-10-12 10:34 ` Koen Kooi [this message]
2010-10-12 12:51 ` Frans Meulenbroeks
2010-10-12 12:53 ` Frans Meulenbroeks
2010-10-12 13:02 ` Koen Kooi
2010-10-12 13:18 ` Frans Meulenbroeks
2010-10-12 14:26 ` Paul Menzel
2010-10-12 21:39 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='i91dk0$7lv$1@dough.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.