From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lo.gmane.org ([80.91.229.12]) by linuxtogo.org with esmtp (Exim 4.69) (envelope-from ) id 1P5eVN-00006W-VT for openembedded-devel@lists.openembedded.org; Tue, 12 Oct 2010 15:02:59 +0200 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1P5eUw-0001dr-7b for openembedded-devel@lists.openembedded.org; Tue, 12 Oct 2010 15:02:30 +0200 Received: from s55917625.adsl.wanadoo.nl ([85.145.118.37]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 12 Oct 2010 15:02:30 +0200 Received: from k.kooi by s55917625.adsl.wanadoo.nl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 12 Oct 2010 15:02:30 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: openembedded-devel@lists.openembedded.org From: Koen Kooi Date: Tue, 12 Oct 2010 15:02:16 +0200 Message-ID: References: <1286783755-19145-1-git-send-email-koen@openembedded.org> Mime-Version: 1.0 X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: s55917625.adsl.wanadoo.nl User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.11) Gecko/20100822 Shredder/3.0.7pre In-Reply-To: X-Enigmail-Version: 1.0.1 X-SA-Exim-Connect-IP: 80.91.229.12 X-SA-Exim-Mail-From: gcho-openembedded-devel@m.gmane.org X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on discovery X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.2.5 X-SA-Exim-Version: 4.2.1 (built Wed, 25 Jun 2008 17:20:07 +0000) X-SA-Exim-Scanned: Yes (on linuxtogo.org) Subject: Re: [PATCHv3 1/3] kernel bbclass: split do_compile into do_compile and do_compile_modules X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Oct 2010 13:02:59 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12-10-10 14:53, Frans Meulenbroeks wrote: > 2010/10/12 Frans Meulenbroeks : >> 2010/10/12 Koen Kooi : > On 12-10-10 12:08, Frans Meulenbroeks wrote: >>>>> 2010/10/12 Koen Kooi : > >>>>>>> +} >>>>>>> + >>>>>>> +do_compile_kernelmodules() { >>>>>>> + unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE >>>>> >>>>> Is it needed/required? > > It is, and it's in kernel.bbclass already: > > fe938bbe (Michael Lauer 2004-12-14) kernel_do_compile() { > 0448ec0d (Richard Purdie 2006-11-20) unset CFLAGS CPPFLAGS CXXFLAGS > LDFLAGS MACHINE > fe938bbe (Michael Lauer 2004-12-14) oe_runmake > include/linux/version.h CC="${KERNEL_CC}" LD="${KERNEL_LD}" > > >>>>> I'm a little bit concerned by this. >>>>> (actually this was the only worry I had after reading the patch, don't >>>>> want to loose additional CFLAGS settings here > > You actually want to do that, since the kernel is bare-metal, not userspace. >>> >> >> Thanks for the answer. >> >> Did a quick peek on CFLAGS in the recipes, saw there is a CFLAGS_KERNEL. >> That one is only used on one place: >> linux-wrt_2.4.30.bb:export CFLAGS_KERNEL="-fno-delayed-branch " >> >> Haven't tested this, but my understanding on how things work is good >> enough and the change simple enough for to give an ack >> Acked-by: Frans Meulenbroeks >> > Actually on 2nd thought one tiny remark left: > after seeing patch 2: > what about renaming: > do_compile_kernelmodules > to something with a kernel prefix > e.g. kernel_do_compile_modules. > That makes the naming scheme somewhat more consistent. Namespacing the class is only used for methods overridden from base.bbclass. Again, look at the rest of kernel.bbclass methods like uboot-mkimage, menuconfig and friends don't use that namespace. And it doesn't actually work since _modules is a local override. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFMtFxYMkyGM64RGpERArFyAKCr5HipFKmy8xsYIoF/U0NIXFfDlwCfferR yhTvF+MOCupbbMMstKVvkmk= =6zMs -----END PGP SIGNATURE-----