From: Mark Marshall <mark.marshall@csr.com>
To: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] vgaarb: use bridges to control VGA routing where possible.
Date: Thu, 16 Dec 2010 12:03:07 +0000 [thread overview]
Message-ID: <iecv5s$8co$1@dough.gmane.org> (raw)
In-Reply-To: <1292478877-19461-1-git-send-email-airlied__3528.0286254876$1292480593$gmane$org@gmail.com>
On 16/12/2010 05:54, Dave Airlie wrote:
> From: Dave Airlie<airlied@redhat.com>
> int pci_set_vga_state(struct pci_dev *dev, bool decode,
> - unsigned int command_bits, bool change_bridge)
> + unsigned int command_bits, u32 flags)
> {
> struct pci_bus *bus;
> struct pci_dev *bridge;
> u16 cmd;
> int rc;
>
> - WARN_ON(command_bits& ~(PCI_COMMAND_IO|PCI_COMMAND_MEMORY));
> + WARN_ON((flags& PCI_VGA_STATE_CHANGE_DECODES)& (command_bits& ~(PCI_COMMAND_IO|PCI_COMMAND_MEMORY)));
Minor thing, but I think the middle & should be a &&?
MM
next prev parent reply other threads:[~2010-12-16 12:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 5:54 [PATCH] vgaarb: use bridges to control VGA routing where possible Dave Airlie
2010-12-16 12:03 ` Mark Marshall [this message]
2010-12-16 14:04 ` Rafał Miłecki
-- strict thread matches above, loose matches on Subject: below --
2010-12-16 5:54 Dave Airlie
2010-12-16 5:54 Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='iecv5s$8co$1@dough.gmane.org' \
--to=mark.marshall@csr.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.