From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBC3433D6E6 for ; Sat, 21 Mar 2026 05:11:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774069875; cv=none; b=jSrQUdfq3CWtPq1HhQhNXyFuMk/ldjHffBmdO8O0L2nr+Qzt5lNV79QdUwtHpXIi7DOp0tTi9uAI1DKkg3TwDdysHePZAzmEztunfHQiiDutWdMq/qMkYVX1bo8twbK6qiCFXJMJ0MG1asXoqwOdlf/I52S7pYSR0rskGJr+MAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774069875; c=relaxed/simple; bh=qVwlCu1WIXntn26q1kvsy4ns7XCLQh3LUnFd91zRr48=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=N+1cvW0vrAstbfbWH+/6sFGXOWVzarsuR/OBHrJGFzLIWGl3X33fGWdV0dyiVYpvpa7VpFRA6AFDylttRjgc6sDh9MbR2LWc6r8qn10iuDA5NlUJrexkjwpyYW3yxEcI9FNoL1/dE0u+68YWf4yhcmPL6jjezXiFOn+K9BnmxsM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OLe7OxhB; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OLe7OxhB" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-c7412b07f22so1590112a12.0 for ; Fri, 20 Mar 2026 22:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774069873; x=1774674673; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=7QxDv7wA5vy2wx/iALi99txiEfbwQ3ENlpnWZYhHz0A=; b=OLe7OxhBzFwMPIltVknpGrXU9DN7TZFVr3dJDvog+FEKXYmG+fHE2bFbgoZCuFCuw2 0eJIPaT+MwpkQBDn5zFbJSu9h2HQa0J7qzB1ZsadIyJ8Bau/FOCcW7WsotI/JazwbOwC Liacvp0OhfIMtoPN1/bsxA1AetNrt12rxXcHel3gly35cWWZocy2wqHD4vswnXxER4SK TKXch+jKp5VDm59qDJg8ua+0OqFS8JstiSXF1Pwy5A8Zcue6JB5wdTTc5OSZOMyh9cCw BYWG4YhdCWoTZ4G1qzRqr0iGs0BgB00W7fAJFkySqVoTIt3dNWFPgkagFcG568A1/AfF xj/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774069873; x=1774674673; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7QxDv7wA5vy2wx/iALi99txiEfbwQ3ENlpnWZYhHz0A=; b=WiAbR2cv5X4f70y1dqQV4cnEqUSoJ+lLCdDwvWM6YH8CaG2kKzta/KnmA/oVpHbYBE eTMTJuSwqEFLZ+bfwnZpYQy8HkB/TDvzpMmqohiVwSwiZRQ1vz/tj9dmuwyOeF2BeS8y 4hOfPKd22a9nsvLdYYH62L4oElDzLb6ORJCPw8UN1EsmASH1PaLrbcfGqakeow0k3K4i RtuiXJb77qd2ZqkShqTO0HUASl3bXzquMVOdUdRG1vpRsYtG34kbyXYPFz50YZKfrusz i1pq+kAIn8RYMmTFSzi/+nIpbXETolesQHpuBdkfSqrxswPPgBh2qXXYa3bRSJB8tPpd jNHA== X-Forwarded-Encrypted: i=1; AJvYcCU2by6N0rs6zpF1xuNKwGSeXaghCM7vGK+hfD39zFn5DY6IcAMfVF9cjB/jvYPQA9i73WU=@vger.kernel.org X-Gm-Message-State: AOJu0YzwJIZLPJpeb/q+kf9c8P5i4oUbrAyA3mVjRl+5t93FYz91YI4k Kaqkn78j53/A+gENmw6B2V7OpWF0y1uM51J5n8MqJv1U0dae5kCsJ6sY X-Gm-Gg: ATEYQzxluqwsJJ+JmZD1azPEGYh8IOtmuvFv9YskarhhNBOJO+v63oU4d7E2qr2izc5 bZoOJa2W/v/ktah97SJpe9P1XQFLIykuVD8sBEVbQ0U856eipqezdeBfHhlOhQGlvSdbTP9AN6R G4tEsphCo/U1bAUMqOYRoRN/kBQqX6guXS9VOgeQZ2M1ruF4h0SDjfqbYF7rmPT1/bJdEj4FRts lO9Dn1GTezKP0u3FHh9qliTuvIOW537JTCETFmBy/085yhR1ZR3f4996nAs9CKIrvnPpQYMK5k7 662+VBILD8Va8bClCWUuw6WCFI90HM82oJ2Gw3GZFWbSd9ky9o9DRDNZh21/4x8/k66ExsgVy9w t/yFUp7bDwQXF/2tqw9QbZ7FUkuuRBRpXsMPt/8tGOFH+N8lWecmbpwm5HSaMpDSXOi3Gi7bfe1 Cs9cMceHdYi60+116DfrFIAQ== X-Received: by 2002:a05:6a21:4cca:b0:39b:9c3a:f54f with SMTP id adf61e73a8af0-39bb25e7511mr8216718637.32.1774069873215; Fri, 20 Mar 2026 22:11:13 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c743a939af0sm2729778a12.16.2026.03.20.22.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 22:11:12 -0700 (PDT) From: Ritesh Harjani (IBM) To: Baolin Wang , akpm@linux-foundation.org, david@kernel.org Cc: ljs@kernel.org, Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, baolin.wang@linux.alibaba.com, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, open , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] mm: change to return bool for ptep_test_and_clear_young() In-Reply-To: <3fa94c3c89fd93fe22c8cb59967f064787d686aa.1773890510.git.baolin.wang@linux.alibaba.com> Date: Fri, 20 Mar 2026 11:27:48 +0530 Message-ID: References: <3fa94c3c89fd93fe22c8cb59967f064787d686aa.1773890510.git.baolin.wang@linux.alibaba.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Baolin Wang writes: > Callers use ptep_test_and_clear_young() to clear the young flag and check > whether it was set. Change the return type to bool to make the intention > clearer. > Right I checked all callers of ptep_test_and_clear_young(). I agree, we only need bool here. > Signed-off-by: Baolin Wang > --- > arch/arm64/include/asm/pgtable.h | 8 ++++---- > arch/arm64/mm/contpte.c | 4 ++-- > arch/microblaze/include/asm/pgtable.h | 2 +- > arch/parisc/include/asm/pgtable.h | 6 +++--- > arch/powerpc/include/asm/book3s/32/pgtable.h | 4 ++-- > arch/powerpc/include/asm/book3s/64/pgtable.h | 6 +++--- > arch/powerpc/include/asm/nohash/pgtable.h | 4 ++-- I looked at it because of powerpc changes, but ended up looking into all call sites anyways. So overall it LGTM (and I agree that we can remove the unnecessary externs from function declarations) With that please feel free to add: Reviewed-by: Ritesh Harjani (IBM) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BC441093170 for ; Sat, 21 Mar 2026 05:11:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:Message-ID:Date: In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ije0LPwFr6My3FEGUBma7t+5rx3ilUFzU29G2HE8d+Q=; b=PfUlPPZdZZ3Kly SCkrwl7Y96m9kZ9vpUn/iJ+cqJYM2viT4u/yKDYim4N9yqsDYOHqPCelUSP7VceFiWozRbLgQkKTg 8zG4+6ecOzRTXkyuMNvTt8cTK2LJRpuQ/IaUJZma6+Gc51H528kim9JBl69O9kkCiT2bDuEyWMgvu PflUg3I6z03noyyjB4nfdQoG/N6iVj+2mPDip4QwY/BHMpkZomOyEnnHmGy1FuL78PfFSmLscYY5p ZpwQfzFJ9DG85L1+JxyhCpbqqGoherQVIkkS5O//RRvZ7PLsm1jMnubvZFqm0MbnbLtvhWYfESqMD MUh5AXy1nRToBAeAwIiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w3ocN-0000000E400-3Y9v; Sat, 21 Mar 2026 05:11:23 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w3ocL-0000000E3yg-33cO for linux-riscv@lists.infradead.org; Sat, 21 Mar 2026 05:11:22 +0000 Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-c742d4df00cso1069272a12.1 for ; Fri, 20 Mar 2026 22:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774069873; x=1774674673; darn=lists.infradead.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=7QxDv7wA5vy2wx/iALi99txiEfbwQ3ENlpnWZYhHz0A=; b=bUB5JwHHYKYptmsax5FiwodWtbIJOAPGj6MtvcDZteioqwqjmo5pwzqwbJaUyZ7PsC 76Xmw50gDF6bG1eQmQ5aj9alPrGdmg4XqPO210FlxZdJSXD2agXM2FYGH7DOys/+2Ykt C4prUM1KbQEho7jGjUJZCNGZHXhSs6F6/5+t4xvSq6q6dgZ1kwtxNY/aG34JZ/T54vLA jCPw3WNAuyRyksrWmG5UJ2Yisic4Vn0qy7Cf3FT0XrFPSIyCLPfV26H2gr3wp+aQxtJk tVPGnteyrN2RSsZ2i4r1XX06ky+AMTyjs60tqXQ+AasxrY3VB5b9TIkq83jlxZ05CRXd E0Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774069873; x=1774674673; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7QxDv7wA5vy2wx/iALi99txiEfbwQ3ENlpnWZYhHz0A=; b=beiy0jJ4izpGrvcIR7DkDyrjlCSeX5nZmAqAZAXYIRGQFzk8ey3bNOkIP9X4XEQ23C qjtpUV4D5frLvKxYqKq0zK1mt+LbZTt0S+jDV4D6Zcg2hSwh6K6BiK7Y0v/5linJapE4 anl9+u4q5F80ALsDajC8IvXsb1v1GsF+sYaq+eXc/nH8xRgEIH5vyuJsktAP5vq/79tn tFUvb+HEqUgi1GrE2PhxhmZpoYOI6tVOOcpdT0/2VPPvSz4flwnCsnhxDZO8zWANFrAk mGkI/J7mO7NO/MyrQbCbR0X4XK1bkMbFE62IYFpbklv8eJcO0allRcLo+MW0SedYocVp i1zQ== X-Forwarded-Encrypted: i=1; AJvYcCWhIFI5XIYvDSys2q9Irmeq5oXy0shS2l82NA6Y2o9WjpB6m1o6IzD14cMYyQe0HL0wtHYPdGtEBYbDxA==@lists.infradead.org X-Gm-Message-State: AOJu0Yy6QHgeh+AiW1cYCcvn3AKTdfsRYUyV4KBd6kvk5b316BlxmNus SwuL/IX7EXwJrEurBjj7hGOz8Zru9X7aLkGGk2hfgepYcqJ/Oca/62Ix X-Gm-Gg: ATEYQzz03CAMdu1fE/OLK1Q/k63vcSO0yplNp5mpLWa4PXOr5HX19S93cVpOH+FTzUN rV9hYCxGRADST7z7if22YDNrHs4QYNCCTb2E6T6mWQzrxX5huiuI+ufKtIiQHv7jafZGQRu2ogE 5e2dkv6LbtK2w40qwBwQqRzqiloyM8E3YctTYp76hYY719l6DAkIttN0WGknldfU01Nw2kogtQd OCXnprJZX/uljZrHpbp7FkiTwBOMpto5VPPzIYfQlmDNwUO14cknNUSs18pPwtE4/oYA+u6r9QF RYkPHRthjyaq3s2MQW1nAXsZvz0/QBKX0vsRA3uc3yIDzW6HqoBD0OiNxtiUW4bXL/FXzg5fGRL ZVE7UDdtnZWq/1TjrtLnEb1FPObqwl5UrYjY+/87PfC1+FEXFdc6yhVSnelDcWUF7ht9v1ZmFfy aog/k9KerJsBgS2sJUbc15xQ== X-Received: by 2002:a05:6a21:4cca:b0:39b:9c3a:f54f with SMTP id adf61e73a8af0-39bb25e7511mr8216718637.32.1774069873215; Fri, 20 Mar 2026 22:11:13 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c743a939af0sm2729778a12.16.2026.03.20.22.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 22:11:12 -0700 (PDT) From: Ritesh Harjani (IBM) To: Baolin Wang , akpm@linux-foundation.org, david@kernel.org Cc: ljs@kernel.org, Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, baolin.wang@linux.alibaba.com, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, open , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] mm: change to return bool for ptep_test_and_clear_young() In-Reply-To: <3fa94c3c89fd93fe22c8cb59967f064787d686aa.1773890510.git.baolin.wang@linux.alibaba.com> Date: Fri, 20 Mar 2026 11:27:48 +0530 Message-ID: References: <3fa94c3c89fd93fe22c8cb59967f064787d686aa.1773890510.git.baolin.wang@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260320_221121_908234_FEFCC1D7 X-CRM114-Status: UNSURE ( 7.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Baolin Wang writes: > Callers use ptep_test_and_clear_young() to clear the young flag and check > whether it was set. Change the return type to bool to make the intention > clearer. > Right I checked all callers of ptep_test_and_clear_young(). I agree, we only need bool here. > Signed-off-by: Baolin Wang > --- > arch/arm64/include/asm/pgtable.h | 8 ++++---- > arch/arm64/mm/contpte.c | 4 ++-- > arch/microblaze/include/asm/pgtable.h | 2 +- > arch/parisc/include/asm/pgtable.h | 6 +++--- > arch/powerpc/include/asm/book3s/32/pgtable.h | 4 ++-- > arch/powerpc/include/asm/book3s/64/pgtable.h | 6 +++--- > arch/powerpc/include/asm/nohash/pgtable.h | 4 ++-- I looked at it because of powerpc changes, but ended up looking into all call sites anyways. So overall it LGTM (and I agree that we can remove the unnecessary externs from function declarations) With that please feel free to add: Reviewed-by: Ritesh Harjani (IBM) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv