All of lore.kernel.org
 help / color / mirror / Atom feed
From: Colin Guthrie <gmane@colin.guthr.ie>
To: alsa-devel@alsa-project.org
Subject: Re: [PATCH] alsa-driver git repo: Build problems when copying symlink to itself
Date: Sat, 12 Mar 2011 10:47:55 +0000	[thread overview]
Message-ID: <ilfj0r$bls$1@dough.gmane.org> (raw)
In-Reply-To: <ilfi0p$7hr$1@dough.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]

'Twas brillig, and Colin Guthrie at 12/03/11 10:30 did gyre and gimble:
> Hi,
> 
> After doing a "simple":
> git clone alsa-driver
> git clone alsa-kernel
> cd alsa-driver
> ./gitcompile --with-debug=full --with-isapnp=yes --with-sequencer=yes
> --with-moddir=updates/alsa:
> 
> The build bombed out pretty quickly with the following error.
> 
> The attached patch fixes it.

And here is another error I stumbled on. The attached patch fixes this.

Hacking autoconf.h...
make[1]: Entering directory
`/home/colin/Development/Personal/ALSA/alsa-driver/include'
make -C sound prepare
make[2]: Entering directory
`/home/colin/Development/Personal/ALSA/alsa-driver/include/sound'
make prepare2
make[3]: Entering directory
`/home/colin/Development/Personal/ALSA/alsa-driver/include/sound'
ln -s ../../alsa-kernel/include/alc5623.h
ln: failed to create symbolic link `./alc5623.h': File exists
make[3]: *** [alc5623.h] Error 1
make[3]: Leaving directory
`/home/colin/Development/Personal/ALSA/alsa-driver/include/sound'
make[2]: *** [prepare] Error 2
make[2]: Leaving directory
`/home/colin/Development/Personal/ALSA/alsa-driver/include/sound'
make[1]: *** [prepare] Error 2
make[1]: Leaving directory
`/home/colin/Development/Personal/ALSA/alsa-driver/include'
make: *** [dep] Error 1


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]

[-- Attachment #2: 0001-Ensure-the-destination-of-the-symlink-doesn-t-yet-ex.patch --]
[-- Type: text/x-patch, Size: 752 bytes --]

>From d7b95b81a62faeab1e565946d91e4771b8128ce0 Mon Sep 17 00:00:00 2001
From: Colin Guthrie <cguthrie@mandriva.org>
Date: Sat, 12 Mar 2011 10:46:39 +0000
Subject: [PATCH] Ensure the destination of the symlink doesn't yet exists.

Similar to my last patch, the symlinking process can also fail due to the
destination file already being present. This ensures we wipe the file first.
---
 include/sound/Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/sound/Makefile b/include/sound/Makefile
index f992c01..0e09df4 100644
--- a/include/sound/Makefile
+++ b/include/sound/Makefile
@@ -16,6 +16,7 @@ version.h: ../version.h
 	patch -p0 -i $< $@
 
 %.h:
+	rm -f $@
 	ln -s $(INCSRC)/$@
 
 .includes.tmp:
-- 
1.7.4.1


[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2011-03-12 10:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-12 10:30 [PATCH] alsa-driver git repo: Build problems when copying symlink to itself Colin Guthrie
2011-03-12 10:47 ` Colin Guthrie [this message]
2011-03-14  9:43 ` Takashi Iwai
2011-03-14 13:16   ` Colin Guthrie
2011-03-14 13:21     ` Takashi Iwai
2011-03-14 15:06       ` Colin Guthrie
2011-03-14 15:14         ` Takashi Iwai
2011-03-14  9:54 ` Jaroslav Kysela
2011-03-14 11:25   ` Colin Guthrie
2011-03-14 13:11     ` Jaroslav Kysela
2011-03-14 13:16     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='ilfj0r$bls$1@dough.gmane.org' \
    --to=gmane@colin.guthr.ie \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.