Re: [PATCH] xbmc: add `libass` to `DEPENDS`

[Koen Kooi <koen@dominion.thruhere.net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 18-03-11 23:18, Paul Menzel wrote:
> Dear Henning,
> 
> 
> Am Freitag, den 18.03.2011, 16:14 +0100 schrieb Henning Heinold:
>> Hi Paul,
>>
>> the problem is this
>>
>> do_configure() {
>>         if [ -e bootstrap.angstrom ] ; then
>>                 sh bootstrap.angstrom
>>         else
>>                 sh bootstrap
>>         fi
>>         oe_runconf
>> }
>>
>>
>> which prevents the autoreconf run and so the regenerating of libtool stuff, which results
>> in that the configure option --with-sysrootdir is not available. I cannt see how
>> your patch is fixing that.
> 
> I think the following goes on. XBMC’s configure script detects that the
> external libass is available and just uses that. XBMC ships all used
> libraries with it, so it is buildable without downloading additional
> stuff (which is of course bad for maintainability reasons). So
> beforehand the configure script set up compilation of the internal
> libass which failed for the reason you pointed out above.
> 
> I build tested this, so it should be fine?

The proper fix is to overhaul the recipe with some help from Tobias, but
till then:

Acked-by: Koen Kooi <koen@dominion.thruhere.net>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNhfukMkyGM64RGpERArNGAJwM47lNVoTT5k0Eor639NlvV2CPtwCfakPW
jdmocV9ZzfpYCnn8pzVhDiI=
=CIjD
-----END PGP SIGNATURE-----