From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lo.gmane.org ([80.91.229.12]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Q72Vs-0002HR-IL for openembedded-devel@lists.openembedded.org; Tue, 05 Apr 2011 11:25:28 +0200 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Q72Tp-00057a-De for openembedded-devel@lists.openembedded.org; Tue, 05 Apr 2011 11:23:21 +0200 Received: from ip545070eb.adsl-surfen.hetnet.nl ([84.80.112.235]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 05 Apr 2011 11:23:21 +0200 Received: from koen by ip545070eb.adsl-surfen.hetnet.nl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 05 Apr 2011 11:23:21 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: openembedded-devel@lists.openembedded.org From: Koen Kooi Date: Tue, 05 Apr 2011 11:23:09 +0200 Message-ID: References: <1300981024-9111-2-git-send-email-obi@opendreambox.org> <1300983264-16652-1-git-send-email-obi@opendreambox.org> <4D99C0EA.5070902@opendreambox.org> <4D99E05E.9020100@opendreambox.org> <4D9A0A1D.3020209@opendreambox.org> <4D9ADC0D.6060603@opendreambox.org> Mime-Version: 1.0 X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: ip545070eb.adsl-surfen.hetnet.nl User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.16) Gecko/20101127 Shredder/3.0.11pre In-Reply-To: <4D9ADC0D.6060603@opendreambox.org> X-Enigmail-Version: 1.0.1 Subject: Re: [PATCHv2] kernel/module-base: Append PR to MACHINE_KERNEL_PR X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2011 09:25:28 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05-04-11 11:08, Andreas Oberritter wrote: > On 04/05/2011 08:22 AM, Koen Kooi wrote: >> On 04-04-11 20:12, Andreas Oberritter wrote: >>> On 04/04/2011 07:54 PM, Koen Kooi wrote: >>>> On 04-04-11 17:14, Andreas Oberritter wrote: >>>>> On 04/04/2011 03:58 PM, Koen Kooi wrote: >>>>>> On 04-04-11 15:00, Andreas Oberritter wrote: >>>>>>> Ping. Any votes for or against this patch with either appended or >>>>>>> prepended PR? >>>>>> >>>>>> I don't like this patch *at all*. Recipes can already do >>>>>> MACHINE_KERNEL_PR_append = "something" if they need to. >>>> >>>>> The use of MACHINE_KERNEL_PR is optional, so it feels really wrong to >>>>> append something to it in a recipe. >>>> >>>>>> Can you should me a specific example on how this would be an improvement? >>>> >>>>> With the version below. a distro can start to use MACHINE_KERNEL_PR any >>>>> time without breaking updates. >>>> >>>>> The vast majority of modules do not use MACHINE_KERNEL_PR >>>> >>>> It seems you don't understand how MACHINE_KERNEL_PR works. The *machine* >>>> sets it. The distro has *no* say in it. Therefore the module recipes >>>> don't need to set it, since it's automatic. >> >>> That's nitpicking. Let me rephrase: >> >>> With the previously cited version. a *machine* can start to use >>> MACHINE_KERNEL_PR any time without breaking updates. >> >>> The vast majority of module recipes do not use MACHINE_KERNEL_PR. That >>> means that they use their own PR instead of appending something to >>> MACHINE_KERNEL_PR, as suggested by you. Setting MACHINE_KERNEL_PR in the >>> machine's configuration disables automatic rebuilds of 91% of module >>> recipes. >> >> So make all the module recipes use MACHINE_KERNEL_PR and ditch PR. > > Thereby making MACHINE_KERNEL_PR mandatory for all machines? I don't see why not. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFNmt99MkyGM64RGpERAsEeAKCFdLTfAEdS0jQsE3roLugG2yvTtQCbBXx7 z2FSA/yy6GVHr8+pASP14e4= =mJV7 -----END PGP SIGNATURE-----