From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23A27319871 for ; Tue, 5 May 2026 10:36:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777977401; cv=none; b=lpOcfYQ/5n4JiSm57ccCfn70tlIoctPdDl4u3Jo1Rf8KwqX7ikkWtECyM2N07eqcto0trH1G+osSMKdQK7BHHvKbFzB/zuT3+lTBE9hs21xE2g5lHXz7UbjBefbnMEqzjrb0LyPo0iiO44QdP8jgClDW7UkmImiCMnSCc+19Euc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777977401; c=relaxed/simple; bh=YYe0UsBMCaRl/SSTsNMvYXizf5N50Ge9yNyjOI2yeog=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=D5wpcaM0Er7pDHbb/5y/qHZqkX4nzSYaQVX1SSCyP4GkVjAi5xJ1fn5eHT0OKyLjppZCJE1HAxmsdXnk3sNTIC4K2W9yVZ00WLkxQx97pA3f4jMMWDHd7nhXtu6qDjdWU1I47TWlXu5D7ck/lqiCY7KmRNXPmyEYEMfsGWJXW/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gvjCcozE; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gvjCcozE" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5a86c1fe573so3564878e87.3 for ; Tue, 05 May 2026 03:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777977398; x=1778582198; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YYe0UsBMCaRl/SSTsNMvYXizf5N50Ge9yNyjOI2yeog=; b=gvjCcozESuQnnv97fTL9JRddJmpK8qoIcIL5jDUtZ44sPvCiH/FvAu4TpGVHxFQeW9 U2pFFK72j0rsuzEWcAilIIVcD/ZcKks0W6G0hFEMtJ7NA8ioIWPpZvMQNE4Y5vg7Oo6q D8l/Y8H7kwqjU1rrWoe4W/4BMfDnRCYP8wnKu0fNLXVCTQiozTLteq5UygULSf3zqXuT tWK/34fEWXcD8MCKGJEERUGK3dh+cCqXWrZDP4fcu3yMHyly7wIQBJsj3e7GHJ5Dd/hX dmqJCRnKuCcEoHA7HMay0ttGtb+RDui/5q09NyhP2R6F6/0iRFZ2j4WwC07SvRzFl8sn ZZmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777977398; x=1778582198; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YYe0UsBMCaRl/SSTsNMvYXizf5N50Ge9yNyjOI2yeog=; b=gkVU4ROM9NYUGB7nZVhmy7Ozj8dOJHHhxwyGuM9t5XfuKjZXqZzCy8B/z0o+5FsLql FYbjvV8hifhcbPoRztMZq2f6vTSjyE3xG/xW1uIDk6CrX9f3ZslCukznn1oze+69Jx1b 7L1oEjfQJy450KmWoFmelYEfF3KymfgiQ/wT7JiHhx4PC5Zbz274YUGQAHuLCCjkJSbj KSK4CaWnQBtWpsbK2hzCuo+DHbJ0lWWhjDos6p049NsjYrvQLhUkAT50GZHCy4MJ3WuU tgHnnUyylqGF284QmJhrKibuewCvvuDZDeE146RKfCVv4RUSbw3tpEC2LpoG5t57118D O0bQ== X-Forwarded-Encrypted: i=1; AFNElJ+FRgKbaEvKv8T745tABJXdkOEcuJFPAA6ASksTbLVsYHP+rZmu2S1X+TO1+TbcReYXX8w4hTGYSZfevsl6D8w=@lists.linux.dev X-Gm-Message-State: AOJu0YzDXO0IVEAw+4LDnRGnAB0fgw9lRdGCIKhG6nasKbAwVOUTWYC+ 1IH9byw73bEIJl9esolyQtG/3o+j0o8pn8GjvWiiLynoqx1PpgwzK+hy X-Gm-Gg: AeBDiesVZbEK3dqf/qgTQtK7qolifjdxvkPZBBtKvnfvUeIm5RvmO8i+EHRCs8I+aV8 Ma0IykzhGo5fO+r+1TweKHIdHtH8g4n5K/9lI6YVv62hwcqCyJSv1v2881Ym2OYqkhtxhQRw754 wsLPdMfU1cyDlvwuto1CsNLDJPkWUk0tfH7Vrf0nXRD5Rx3XJmk3iHEzod8LYBLCzSV8STfqQMO vineE0D8XesgWEAEa2mw8tzw5MlKFXfHffGx/90t6sjHXrdi2qVf9BkVoDefe90SbYR0Gv414Gh DutfFoNhlmVsBI6fJZB58u8dGG1f0mzEq/2wQcZ9/ujtLuJpoSfpoUeW6myH/B+VfypRvncLhgE wDD0TYdG4Q8EXnJwN4mFqqiHkWuq14u1DMwHxb9v7M2iHnGT2fLvRUM6mdsojX7apHq8Nby56ME 9+xqzCKMohJvx49LbZp1bvIHrB5WebfzY2z+dakxeBkjgnOv6zxEBy3HYUsQZ5bbAoZt6/iv4= X-Received: by 2002:a05:6512:800e:20b0:5a8:6391:4fe5 with SMTP id 2adb3069b0e04-5a863915030mr3062779e87.26.1777977397888; Tue, 05 May 2026 03:36:37 -0700 (PDT) Received: from va-HP-Pavilion-Desktop-595-p0xxx.mshome.net ([193.0.150.248]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c341848sm3774443e87.65.2026.05.05.03.36.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 03:36:37 -0700 (PDT) From: Valery Borovsky To: Will Deacon Cc: Mark Rutland , Arnd Bergmann , Greg Kroah-Hartman , Benson Leung , Tzung-Bi Shih , Guenter Roeck , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Andy Shevchenko , Linus Walleij , Randy Dunlap , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, linux-mtd@lists.infradead.org, Valery Borovsky Subject: Re: [PATCH 1/5] perf/arm_pmu_acpi: fix reference leak in arm_pmu_acpi_probe error path Date: Tue, 5 May 2026 13:36:27 +0300 Message-ID: X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Yeah, you're right, my bad. The `arm_pmu_acpi.c` patch is definitely broken. Since `spe_dev` and `trbe_dev` are statically allocated, they don't have a `.dev.release` callback. If we hit `platform_device_put()` here, the refcount drops to zero and triggers `device_release()`, which is going to scream about the missing release function. At best, we get a messy WARN; at worst, it'll panic the kernel if someone's running with `panic_on_warn`. The kernel-doc note about `platform_device_put()` is really meant for dynamic allocations where the release path actually frees memory. For static setups like this, the original code is actually the right way to go. Please drop patches 1/5 through 4/5 from the v1 series—they all suffer from the same logic error. Patch 5/5 (mfd: sm501) is the only clean one, so I've re-sent that as a standalone v2. Sorry for the noise. Valery Borovsky From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF4DDFF885A for ; Tue, 5 May 2026 10:36:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NOO9u0gUdr5V2U+NhZcvpGMDRjTXpk7vHl4hrGeYWqA=; b=iSuPTEzZe+RXff VdHntzxBKbDWe3se3BnfD5cGy/wKGlHl4DBcLMJY9Hc367UKL7rvM5aptkBfTSs5fqVwuybm5GYPa GxA2QeJ4vTIMtmpJkFSeffkgPjKfcPOPZyI5vmszxiKBjGuG0Xj9mgMOl0jDlCRC2lQxWtQPLNWgI /3txC+pYWLgZVxmgEuwRvS9lTEUDls5cobiap1+6mOtwHY4fskfyenYt9Mw/6qRHMw4ysaCZdTpF1 7sIKmbB2m9efpopPNwvgELl6bckhLOzGCV+nqgK3jU14ami5qQ4V61euRO0h8VESt1mjHFlI96I78 WaUrV8TOXDSBbQ8aRfsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wKD8u-0000000FuHy-2LPP; Tue, 05 May 2026 10:36:44 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wKD8q-0000000FuGl-3dVw for linux-mtd@lists.infradead.org; Tue, 05 May 2026 10:36:41 +0000 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-5a2c3dfb4a1so4816096e87.2 for ; Tue, 05 May 2026 03:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777977398; x=1778582198; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YYe0UsBMCaRl/SSTsNMvYXizf5N50Ge9yNyjOI2yeog=; b=I8/mx/z4Cjdnt7/uBs2Jmjn7sb9OEOL89aM9CNKXG/0pjASy1CoNHghEIfS42Txi/B UYKPdsGzxQh9182rtHtZfkAPMyOTLd2ZMTxfdC6uGs9GbtnhR6TDKNXSCnJ76pXFppAa K9zStiVgNMbTqvPZ6WgsF/om34GQFORCFHRO6iAJ2gynMWdnLDXp3lN5FT5S+nxcQD/Q oWwSbcbx8BUOQ9rp9ikvrJPnanJorloUQ4TfzGT+XLyv0Kl9QOOTnVT7FAXc4NY1/gaP q++IB9Y1NO1WvVUOJclCLclYKgmgDmxjIxmNPaaoiObYbpg0P5CVx7JKglG7yLReqrzn e1PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777977398; x=1778582198; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YYe0UsBMCaRl/SSTsNMvYXizf5N50Ge9yNyjOI2yeog=; b=ZpBnMqXLqEysaTUz2GgEGZ+XzbukjFBEvD4/STRl0Gk6PbwkUWZdcJoQf1NjvmnPQe 3w0XR6Ey6NFX5avvu6lxdX/CqnzMMaJYdCHILFqdABzy/0Gr6fzQsp35t4B76E56kHsC LDNSmd1QKxEmYRbNOMx3nYJ53W8iIkKmT2pcn3HyGzriPKOGgJ0Oc/ftlwLaa9m7vzms eYbKrOqI36hlrZ/nuNuvniQWFo6QH4srFq0F3Cpri8xmPFwNNEIkStHbjsKzms7sevtx 5OguN3T8HrR7ETlOaLpvbpluzIKGMi2jDjCUx/4E8FnjL10xxahrnim549rqBVWhv2XN jVmA== X-Forwarded-Encrypted: i=1; AFNElJ+sgpfNi0vMJvZ/Ozm0vSXVSUJXXC6aIMse0IzNR2CyqMWM2sk2UP8d2CTiAH+Uy2r6iUXgjBK8c3M=@lists.infradead.org X-Gm-Message-State: AOJu0Yx9UdetIirfPtpyxT4GWBpzEyfnbhsZGgpgS2cNMFqrvKkumfbE 9BKwnrjfyTKKySJDOZXAQaqpBBJut5AfnncNLIWAnLxx95olrqrLL80t X-Gm-Gg: AeBDievMvcCBwl634j0nfw51pUGI7s+iVljB8wWJhUWDKiYOKzInx+DueULT60SO1i0 r+K1Bf+XnK41/9OdOgSNVCIh805ai0xgC5DXnem6sE06nCDRIbS9FT2EOP+U3ePRSdWgks8X9HW bLaiPJzBjzIKVu/PNLwKjkKz6fzkdt6wBzuhxAk+sx/o9C/RjkwRDUPu7aZS+rwUYZAnjrx6WGx t4xqjakpE0L+DdKKsJ9f6uI7DjjyzJOH5sJlkcglkcE28/H1BQ8BGyLp8TjlRIZup+iTH76feMA E/7udjHgq2S1Y9MRYicwLpffAx+YVBwjcbMThC1ZZGa+czxl17uZYYWTG0MfzSJhxtOQEdFjgju aYKDq9qfDPmFl3HOZ7NP0V37Xar47s3ISr/Fy9N06o0klCzLrE4Z2+Ra3inl9SuIY+YEHFMOMbT UhqwwZe9jDSUGSq/+n/8j/je3Ve7u1Q91P3ZMMRUgN+I+csnA6tcIHk7Hl9+94k9xEqtIuAoY= X-Received: by 2002:a05:6512:800e:20b0:5a8:6391:4fe5 with SMTP id 2adb3069b0e04-5a863915030mr3062779e87.26.1777977397888; Tue, 05 May 2026 03:36:37 -0700 (PDT) Received: from va-HP-Pavilion-Desktop-595-p0xxx.mshome.net ([193.0.150.248]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c341848sm3774443e87.65.2026.05.05.03.36.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 03:36:37 -0700 (PDT) From: Valery Borovsky To: Will Deacon Cc: Mark Rutland , Arnd Bergmann , Greg Kroah-Hartman , Benson Leung , Tzung-Bi Shih , Guenter Roeck , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Andy Shevchenko , Linus Walleij , Randy Dunlap , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, linux-mtd@lists.infradead.org, Valery Borovsky Subject: Re: [PATCH 1/5] perf/arm_pmu_acpi: fix reference leak in arm_pmu_acpi_probe error path Date: Tue, 5 May 2026 13:36:27 +0300 Message-ID: X-Mailer: git-send-email 2.51.0 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260505_033640_917476_D3376959 X-CRM114-Status: GOOD ( 11.53 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org WWVhaCwgeW91J3JlIHJpZ2h0LCBteSBiYWQuIFRoZSBgYXJtX3BtdV9hY3BpLmNgIHBhdGNoIGlz IGRlZmluaXRlbHkgYnJva2VuLgoKU2luY2UgYHNwZV9kZXZgIGFuZCBgdHJiZV9kZXZgIGFyZSBz dGF0aWNhbGx5IGFsbG9jYXRlZCwgdGhleSBkb24ndCBoYXZlIGEKYC5kZXYucmVsZWFzZWAgY2Fs bGJhY2suIElmIHdlIGhpdCBgcGxhdGZvcm1fZGV2aWNlX3B1dCgpYCBoZXJlLCB0aGUgcmVmY291 bnQKZHJvcHMgdG8gemVybyBhbmQgdHJpZ2dlcnMgYGRldmljZV9yZWxlYXNlKClgLCB3aGljaCBp cyBnb2luZyB0byBzY3JlYW0gYWJvdXQKdGhlIG1pc3NpbmcgcmVsZWFzZSBmdW5jdGlvbi4gQXQg YmVzdCwgd2UgZ2V0IGEgbWVzc3kgV0FSTjsgYXQgd29yc3QsIGl0J2xsCnBhbmljIHRoZSBrZXJu ZWwgaWYgc29tZW9uZSdzIHJ1bm5pbmcgd2l0aCBgcGFuaWNfb25fd2FybmAuCgpUaGUga2VybmVs LWRvYyBub3RlIGFib3V0IGBwbGF0Zm9ybV9kZXZpY2VfcHV0KClgIGlzIHJlYWxseSBtZWFudCBm b3IgZHluYW1pYwphbGxvY2F0aW9ucyB3aGVyZSB0aGUgcmVsZWFzZSBwYXRoIGFjdHVhbGx5IGZy ZWVzIG1lbW9yeS4gRm9yIHN0YXRpYyBzZXR1cHMKbGlrZSB0aGlzLCB0aGUgb3JpZ2luYWwgY29k ZSBpcyBhY3R1YWxseSB0aGUgcmlnaHQgd2F5IHRvIGdvLgoKUGxlYXNlIGRyb3AgcGF0Y2hlcyAx LzUgdGhyb3VnaCA0LzUgZnJvbSB0aGUgdjEgc2VyaWVz4oCUdGhleSBhbGwgc3VmZmVyIGZyb20K dGhlIHNhbWUgbG9naWMgZXJyb3IuIFBhdGNoIDUvNSAobWZkOiBzbTUwMSkgaXMgdGhlIG9ubHkg Y2xlYW4gb25lLCBzbyBJJ3ZlCnJlLXNlbnQgdGhhdCBhcyBhIHN0YW5kYWxvbmUgdjIuCgpTb3Jy eSBmb3IgdGhlIG5vaXNlLgoKVmFsZXJ5IEJvcm92c2t5CgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFp bGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtbXRkLwo=