Re: [PATCH] gst-ffmpeg: Add support for NEON optimization on armv7a

[Koen Kooi <koen@dominion.thruhere.net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06-05-11 15:33, Punya Prakash wrote:
> * Patch gst-ffmpeg configure script to allow passing extra config options
> 	* without this change parsinig of configuration for FFmpeg/libav fails for parameters like --with-ffmpeg-extra-configure="--extra-cflags='-mfpu=neon -mfloat-abi=softfp'"
> * note: this patch has been accepted upstream to the mainline project
> 	* commit cc9d778844078d0eb2c23c7a11f7f855d013bca5
> 	* Target Milestone HEAD 0.10.12

I have a comment and a nitpick, let's start with the nitpick first:

> +EXTRA_OECONF_armv7a = ' --with-ffmpeg-extra-configure="  --target-os=linux --extra-cflags='-march=armv7-a -mfpu=neon -mfloat-abi=softfp'"'

You're hardcoding linux and fb abi, which is bad.

Now the the comment:

This patch is useless, we link to the external libav (EXTRA_OECONF = "
- --with-system-ffmpeg"), which is built with the correct options. So this
patch has no effect and the way it's trying to achieve it is wrong, so:

NAK

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNxD6aMkyGM64RGpERAqzYAJ9Hy9QLRDLiKKtjcT/rtZrSrzYRqQCgr74M
wBFPHk+vCnXe1K+kS0MzIDE=
=H6dO
-----END PGP SIGNATURE-----