From: Koen Kooi <koen@dominion.thruhere.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] kernel.bbclass: pass KERNEL_VERSION through legitimize_package_name
Date: Fri, 20 May 2011 21:29:24 +0200 [thread overview]
Message-ID: <ir6fek$pn6$1@dough.gmane.org> (raw)
In-Reply-To: <1305916565-15441-1-git-send-email-raj.khem@gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 20-05-11 20:36, raj.khem@gmail.com wrote:
> From: Andreas Oberritter <obi@opendreambox.org>
>
> - KERNEL_VERSION may contain characters unsuitable for package
> names, e.g. underscores. Use legitimize_package_name to replace
> those characters.
>
> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
> Acked-by: Phil Blundell <philb@gnu.org>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
I cherry-picked it before I read this mail :)
> ---
> meta-oe/classes/kernel.bbclass | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-oe/classes/kernel.bbclass b/meta-oe/classes/kernel.bbclass
> index e1e8197..7498c2c 100644
> --- a/meta-oe/classes/kernel.bbclass
> +++ b/meta-oe/classes/kernel.bbclass
> @@ -238,8 +238,8 @@ RDEPENDS_kernel = "kernel-base"
> # Allow machines to override this dependency if kernel image files are
> # not wanted in images as standard
> RDEPENDS_kernel-base ?= "kernel-image"
> -PKG_kernel-image = "kernel-image-${KERNEL_VERSION}"
> -PKG_kernel-base = "kernel-${KERNEL_VERSION}"
> +PKG_kernel-image = "kernel-image-${@legitimize_package_name('${KERNEL_VERSION}')}"
> +PKG_kernel-base = "kernel-${@legitimize_package_name('${KERNEL_VERSION}')}"
> ALLOW_EMPTY_kernel = "1"
> ALLOW_EMPTY_kernel-base = "1"
> ALLOW_EMPTY_kernel-image = "1"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFN1sEUMkyGM64RGpERAjvUAJ9gAyp9fGBU7hcAew6Wdz5plpPQlQCeOaBj
1921JJIJCRaUxllK+OjYX1g=
=4BLe
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2011-05-20 19:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 18:36 [meta-oe][PATCH] kernel.bbclass: pass KERNEL_VERSION through legitimize_package_name raj.khem
2011-05-20 19:29 ` Koen Kooi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ir6fek$pn6$1@dough.gmane.org' \
--to=koen@dominion.thruhere.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.