From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lo.gmane.org ([80.91.229.12]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1QPEsT-0005EF-QK for openembedded-devel@lists.openembedded.org; Wed, 25 May 2011 16:16:01 +0200 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QPEpV-0006UI-VA for openembedded-devel@lists.openembedded.org; Wed, 25 May 2011 16:12:57 +0200 Received: from ip545070eb.adsl-surfen.hetnet.nl ([84.80.112.235]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 25 May 2011 16:12:57 +0200 Received: from koen by ip545070eb.adsl-surfen.hetnet.nl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 25 May 2011 16:12:57 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: openembedded-devel@lists.openembedded.org From: Koen Kooi Date: Wed, 25 May 2011 16:12:45 +0200 Message-ID: References: <1306328337-19285-1-git-send-email-eyalr@ti.com> <4DDD05E0.4070504@opendreambox.org> <1306332204.10056.81.camel@mattotaupa> Mime-Version: 1.0 X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: ip545070eb.adsl-surfen.hetnet.nl User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.16) Gecko/20101127 Shredder/3.0.11pre In-Reply-To: <1306332204.10056.81.camel@mattotaupa> X-Enigmail-Version: 1.0.1 Subject: Re: [PATCH] wpa-gui-e: build the latest version from git sources X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2011 14:16:01 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 25-05-11 16:03, Paul Menzel wrote: > Dear Andreas, dear Eyal, > > > On Mi, 2011-05-25 at 15:36 +0200, Andreas Oberritter wrote: > >> On 05/25/2011 02:58 PM, Eyal Reizer wrote: > > […] > >>> +SRCREV = "b8fb017272ed4794339978c9fbc0e74571a44728" >>> +PR = "r0" >> >> PR = "r0" is the default and can be removed. > > it seems there are different opinions on this topic. At least the manual > says differently. > > Note > > It is good practice to always define PR in your recipes, even > for the "r0" release, so that when editing the recipe it is > clear that the PR number needs to be updated. > > You should always increment PR when modifying a recipe. > Sometimes this can be avoided if the change will have no effect > on the actual packages generated by the recipe, such as updating > the SRC_URI to point to a new host. If in any doubt then you > should increase the PR regardless of what has been changed. > > The PR value should never be decremented. If you accidentally > submit a large PR value for example then it should be left at > the value and just increased for new releases, not reset back to > a lower version. > >>> +PV = "0.7.3+0.8.0-rc" >>> +PR_append = "+gitr${SRCPV}" >> >> SRCPV should not be used in PR (even if it's been copied from another >> recipe which does it wrong). > > I am still confused about this one. That is why I still have not > committed the pkg-config patch yet [2]. Could the right way be > documented in the manual. It is completely OK to use it in PR if you want the hash in PR, but not PV. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFN3Q5dMkyGM64RGpERAhwhAKCKxo/HdbjYY90JHWbgtyiGCMwLFQCgiaRa HB1AMRMFaS/r4+iF6S6wa5M= =XI4d -----END PGP SIGNATURE-----