All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lutz Vieweg <lvml@5t9.de>
To: linux-raid@vger.kernel.org
Subject: Re: Using the new bad-block-log in md for Linux 3.1
Date: Wed, 27 Jul 2011 14:30:30 +0200	[thread overview]
Message-ID: <j0p0d6$aj6$1@dough.gmane.org> (raw)
In-Reply-To: <20110727141652.7511fc51@notabene.brown>

On 07/27/2011 06:16 AM, NeilBrown wrote:
> Then as errors occur they will cause the faulty block to be added to the log rather
> than the device to be remove from the array.

Can you describe the criteria for MD considering a block as faulty?

In your blog, I read
  "... known to be bad. i.e. either a read or a write has recently failed..."
but that definition may be problematic: I've experienced drives
with intermittent read / write failures (due to controller or power stability
problems), and I wonder whether such a situation could quickly fill up the
"bad block list", doing more harm than good in the "intermittent error"-
szenario.

Another szenario: The write succeeded, but a later reads of the same
block return read errors. This would result in a "pending sector", and the
harddisk may very well re-map the sector on the next write. Do you mark
the block faulty on the MD level after the first read failed (even though
subsequent reads/writes to the block would succeed), or do you first try
to re-write the block, and call it faulty only if that fails?

One more general thing: I guess that "marking bad blocks" is probably
unsuitable for SSDs, which usually do not assign fixed physical
storage location with a certain block number. Maybe mdadm could warn about better
not enabling the feature if the device is known to be a SSD.


Regards,

Lutz Vieweg



  parent reply	other threads:[~2011-07-27 12:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-27  4:16 Using the new bad-block-log in md for Linux 3.1 NeilBrown
2011-07-27  6:21 ` keld
2011-07-27  6:49   ` NeilBrown
2011-07-27  8:17     ` keld
2011-07-27 10:22       ` Mikael Abrahamsson
2011-07-27 12:30 ` Lutz Vieweg [this message]
2011-07-27 12:44   ` John Robinson
2011-07-27 13:06     ` Lutz Vieweg
2011-07-27 13:23       ` Lutz Vieweg
2011-07-27 20:55       ` NeilBrown
2011-07-28  9:25         ` Lutz Vieweg
2011-07-28  9:55           ` John Robinson
2011-07-28 12:53 ` Michal Soltys

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='j0p0d6$aj6$1@dough.gmane.org' \
    --to=lvml@5t9.de \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.