From: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>
To: linux-btrfs@vger.kernel.org
Subject: Re: bonnie triggers and endless numbers of stack traces
Date: Fri, 19 Aug 2011 19:28:37 +0200 [thread overview]
Message-ID: <j2m6g5$7f3$1@dough.gmane.org> (raw)
In-Reply-To: <j2m3ud$u8e$1@dough.gmane.org>
I think we either should remove it or replace by WARN_ON_ONCE()
Remove WARN_ON(1) in a common code path
From: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>
Something like bonnie++ -d /mnt/btrfs -s0 -n 1:256:256:1 -r 0
will trigger lots of those WARN_ON(1), so lets remove it.
Signed-off-by: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>
---
fs/btrfs/extent-tree.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 80d6148..1d1a8d0 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -5708,7 +5708,6 @@ use_block_rsv(struct btrfs_trans_handle *trans,
if (!ret)
return block_rsv;
if (ret) {
- WARN_ON(1);
ret = reserve_metadata_bytes(trans, root, block_rsv, blocksize,
0);
if (!ret) {
next prev parent reply other threads:[~2011-08-19 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 16:45 bonnie triggers and endless numbers of stack traces Bernd Schubert
2011-08-19 17:28 ` Bernd Schubert [this message]
2011-08-19 19:36 ` Josef Bacik
2011-08-19 23:45 ` David Sterba
2011-08-22 8:17 ` Bernd Schubert
2011-08-29 18:42 ` [PATCH debug] btrfs: ratelimit WARN_ON in use_block_rsv David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='j2m6g5$7f3$1@dough.gmane.org' \
--to=bernd.schubert@itwm.fraunhofer.de \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.