From: Koen Kooi <koen@dominion.thruhere.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: `PR = "r0"`: Add or not to add?
Date: Wed, 31 Aug 2011 14:45:22 +0200 [thread overview]
Message-ID: <j3lad2$v75$2@dough.gmane.org> (raw)
In-Reply-To: <CAP9ODKrs1WvLOpHNKsJu0Uf7_8zFQ_GPrPz=+ttdy5tces2gjw@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 31-08-11 14:34, Otavio Salvador schreef:
> On Wed, Aug 31, 2011 at 09:16, Koen Kooi <koen@dominion.thruhere.net>
> wrote:
>>>>>> please remove PR in new recipes
>>>>> Actually I would favor to leave them in.
>>>> Well I don't, and atm I decide if it goes in or not.
>>>
>>> To sad. It's a lot easier to remember to bump the PR, when PR
>>> actually is in the recipe. Thus, including PR=0 will often remove one
>>> issue with patches.
>>
>> That's what review is for, no?
>
> Review is to check for mistakes and dropping PR from new recipes just
> makes hard for new users and put more work for people to review.
>
> Please accept PR = "r0" on new recipes since it makes it more consistent
> and easy to new users.
Consistent in what way? If you want to be consistent you need to add *all*
variables to the recipe and set it to their default.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFOXiziMkyGM64RGpERArVFAJ9XOjQIEyuO2O170XTAlyduOxMYYwCeOXzk
oxzHXdyhx78QoZZOu/owDUU=
=J5Ow
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-08-31 12:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 23:06 [meta-xfce] thunar-volman: Add initial recipe with version 0.6.0 Andreas Müller
2011-08-31 7:15 ` Koen Kooi
2011-08-31 10:06 ` `PR = "r0"`: Add or not to add? (was: thunar-volman: Add initial recipe with version 0.6.0) Paul Menzel
2011-08-31 10:23 ` `PR = "r0"`: Add or not to add? Koen Kooi
2011-08-31 11:45 ` Frans Meulenbroeks
2011-08-31 11:55 ` Anders Darander
2011-08-31 12:16 ` Koen Kooi
2011-08-31 12:27 ` Paul Eggleton
2011-08-31 12:33 ` Frans Meulenbroeks
2011-08-31 12:36 ` Koen Kooi
2011-08-31 12:43 ` Anders Darander
2011-08-31 13:00 ` Koen Kooi
2011-08-31 13:19 ` Anders Darander
2011-08-31 14:10 ` Frans Meulenbroeks
2011-08-31 12:29 ` Anders Darander
2011-08-31 12:34 ` Otavio Salvador
2011-08-31 12:45 ` Koen Kooi [this message]
2011-08-31 13:02 ` Otavio Salvador
2011-08-31 13:30 ` Koen Kooi
2011-08-31 13:43 ` Otavio Salvador
2011-08-31 22:35 ` Philip Balister
2011-09-01 10:06 ` Frans Meulenbroeks
2011-09-05 10:22 ` Ahsan, Noor
2011-08-31 13:49 ` Paul Menzel
2011-08-31 14:07 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='j3lad2$v75$2@dough.gmane.org' \
--to=koen@dominion.thruhere.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.