Re: [PATCH] mbsrtowcs, mbsnrtowcs: wfix

["David Prévot" <taffit-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Michael,

Le 16/10/2011 02:09, Michael Kerrisk a écrit :

> and you meant in both cases to change "null wide" to
> "null", right?

Sure, sorry about that.

> But, more generally, I think you are saying that there were some
> pieces of my older e9c23bc636426366d659809bc99cd84661e86464 that
> incorrectly changed "[terminating] null character" to "[terminating]
> null wide character", right?

I didn't checked them all (yet), but your example bellow seems to concur
with that assumption.

> I suspect that the first of my changes to mbstowcs.3 below was
> also incorrect. Can you confirm?

>  The multibyte string has been completely converted, including the
> -terminating \(aq\\0\(aq.
> +terminating null wide character (\(aq\\0\(aq).

The change is indeed wrong, since \(aq\\0\(aq (i.e. '\0') is the
terminating null byte (or character, but I think you tried to
consistently use “byte” in your last changes), which is different from
L\(aq\\0\(aq (i.e. L'\0'), the terminating null wide character.

> PS See also 3c81e148a228550b4ce3d20a9c68ce0eb91cef07, which I just
> pushed (to github). Do you agree with that change?

Given the context (wide → multibyte), I agree that the “terminating
null” in the destination string should be the terminating null byte
('\0'), but I didn't check the source code, or didn't test it either
(just came across the previous inconsistencies while updating the French
translations of these pages).

Regards

David

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJOmtj+AAoJELgqIXr9/gny9P4QAKWp9R22ZaSzHEPycEgcsqSw
/H+BwFGpCgEX+Z0AWm2NSX4gc+5XPiX/gJQpOkFzMlRJ17no6KfLEaxSxV8cHKzJ
8NnYa6eK5KMbCg4QBicNi6BKiiLj35QY1h3h70HX/pmcbr0gmbEexuqj/dwnwBPB
1WPwpZ3fcNzCYRDZzEkzXOfXhoFlGC+XfOOC5Uwn56TEXx03gGFeJsCTRW9V7lzX
0VL9n8E3FLGJSW8Am/EQ8hGzwGbiuzXaJntkwNj3b5kaof/wc7iwo82xwgX3Nc+K
l6+d+NuK1hbY8Cvu81B0jOtv6MTdPR14x5lo0YtM/onLHKs5a4Rt149/sH0zlGQO
uAEh+FEv59D0qvJkkeZsXpWjehqs1YJDv82bRcfz5H4ZIVUzJTnKhBQnI4MjX2m9
gTNg1eiC7+Jt0qge5L7PRwVGuxiCI1MG5tGeogiGdv/GCEIqJ6OFwQjeFjk3Iz1m
pTvm0AcLyNz/w70rGQ8vfIsPscuIy1tY0t00vioIDaHv6kAdCuYVytU33OHK5jWQ
xdXMwWGdwWH1nYjhYU5gwoFsQUQpgmHugwTgXsEIgvgvopGp9OhHLd+kcDUw7Uyn
3HVBdDG522B4TwstBTdpyMMhlOgRAGvBHsfYVrvtIecHm/JgxLwoPr2KLyC1n9MD
/iuRZR2+K6YdTAfen3vi
=B/Qv
-----END PGP SIGNATURE-----

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html