From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47959)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RG8Kk-0004wM-JU
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 07:59:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RG8Kj-0004KH-AM
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 07:59:50 -0400
Received: from lo.gmane.org ([80.91.229.12]:52371)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RG8Kj-0004Jy-5B
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 07:59:49 -0400
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RG8Kg-0005NP-41
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 13:59:46 +0200
Received: from 93-34-218-143.ip51.fastwebnet.it ([93.34.218.143])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Tue, 18 Oct 2011 13:59:46 +0200
Received: from pbonzini by 93-34-218-143.ip51.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Tue, 18 Oct 2011 13:59:46 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Tue, 18 Oct 2011 13:59:33 +0200
Message-ID: <j7jpn5$bom$1@dough.gmane.org>
References: <1318332930-16217-1-git-send-email-pbonzini@redhat.com>	<4E9C8878.8010406@codemonkey.ws>
	<4E9C8B8D.90108@redhat.com> <4E9C8BF9.7090108@codemonkey.ws>
	<j7i2lb$egj$1@dough.gmane.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <j7i2lb$egj$1@dough.gmane.org>
Subject: Re: [Qemu-devel] [PATCH v2 00/13] allow tools to use the QEMU main
	loop
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 10/17/2011 10:19 PM, Paolo Bonzini wrote:
> On 10/17/2011 10:11 PM, Anthony Liguori wrote:
>>> Leftover from RFC. Right now, this is just a chainsaw cleanup.
>>> However, Kevin
>>> has plans to use the main loop everywhere (making qemu-io and qemu-img
>>> one huge
>>> coroutine).
>>
>> Can you add something to docs that explains how to use the new main loop?
>
> Yes, of course.

Is it okay to just move more functions to main-loop.h (bottom halves, 
lock/unlock iothread, child watch) and add doc comments there?

If so, I can send the 2 updated patches (main-loop.h/main-loop.c) for 
review, and push again to github.

Paolo