Re: [PATCH 1/2] net: add network priority cgroup infrastructure

[WANG Cong <xiyou.wangcong@gmail.com>]

On Wed, 16 Nov 2011 15:51:05 -0500, Neil Horman wrote:
 
> +static void cgrp_destroy(struct cgroup_subsys *ss, struct cgroup *cgrp)
> +{
> +	struct cgroup_netprio_state *cs;
> +	struct net_device *dev;
> +
> +	cs = cgrp_netprio_state(cgrp);
> +	rtnl_lock();
> +	for_each_netdev(&init_net, dev) {
> +		if (dev->priomap)
> +			dev->priomap->priomap[cs->prioidx] = 0; 
> +	}
> +	rtnl_unlock();
> +	put_prioidx(cs->prioidx);
> +out_free:
> +	kfree(cs);
> +}

'out_free' is unused.


> +
> +static int write_priomap(struct cgroup *cgrp, struct cftype *cft, 
> +			 const char *buffer)
> +{
> +	char *devname = kstrdup(buffer, GFP_KERNEL); 
> +	int ret = -EINVAL;
> +	u32 prioidx = cgrp_netprio_state(cgrp)->prioidx; 
> +	unsigned long priority;
> +	char *priostr;
> +	struct net_device *dev;
> +
> +	devname = kstrdup(buffer, GFP_KERNEL); 


kstrdup() is called twice...


Thanks.