From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:32861)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RQyNM-0006R2-S8
	for qemu-devel@nongnu.org; Thu, 17 Nov 2011 04:35:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RQyNG-0002Ui-FX
	for qemu-devel@nongnu.org; Thu, 17 Nov 2011 04:35:20 -0500
Received: from lo.gmane.org ([80.91.229.12]:50960)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RQyNG-0002Ud-9A
	for qemu-devel@nongnu.org; Thu, 17 Nov 2011 04:35:14 -0500
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RQyNE-0005b1-My
	for qemu-devel@nongnu.org; Thu, 17 Nov 2011 10:35:12 +0100
Received: from 93-34-207-114.ip51.fastwebnet.it ([93.34.207.114])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 17 Nov 2011 10:35:12 +0100
Received: from pbonzini by 93-34-207-114.ip51.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 17 Nov 2011 10:35:12 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu, 17 Nov 2011 10:31:27 +0100
Message-ID: <ja2k9f$jdo$2@dough.gmane.org>
References: <20111116215829.GA767@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <20111116215829.GA767@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] Makefile: fix qga dependencies
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 11/16/2011 10:58 PM, Michael S. Tsirkin wrote:
> .c files include .h files, so .o depends on .h,
> and the linked result depends on .o.
> We got it wrong for qga rules, fix it up.

Another possible option is to make the "all" target depend on 
GENERATED_HEADERS and GENERATED_SOURCES, like

all: $(GENERATED_HEADERS) $(GENERATED_SOURCES)
	@$(MAKE) build-all

and drop the dependency everywhere else.  This will check the dependency 
at the beginning of the build (should be fine since the generated files 
change rarely) and rely on automatic dependency generation for the 
.o->.h dependencies.

Paolo