From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V2] Add -f option to qemu-nbd
Date: Wed, 23 Nov 2011 08:24:05 +0100 [thread overview]
Message-ID: <jai72l$iao$1@dough.gmane.org> (raw)
In-Reply-To: <4ECD32BF0200006600006F28@novprvlin0050.provo.novell.com>
On 11/23/2011 07:51 AM, Chun Yan Liu wrote:
>
> According to above code logic, if lock in an early place is not
> accepted, then removing CLEAR_SOCK in nbd_init phase can also solve
> problem. In fact, if cleanup work done well, I think that ioctl is not
> needed. Any comments?
I think you're right. In addition, SET_BLKSIZE and SET_SIZE should not
be sent unless SET_SOCK succeeds.
Paolo
prev parent reply other threads:[~2011-11-23 7:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 11:36 [Qemu-devel] [PATCH V2] Add -f option to qemu-nbd Chunyan Liu
2011-11-17 13:41 ` Paolo Bonzini
2011-11-17 13:52 ` Stefan Hajnoczi
2011-11-18 1:25 ` Chun Yan Liu
2011-11-18 8:59 ` Paolo Bonzini
2011-11-23 6:51 ` Chun Yan Liu
2011-11-23 7:24 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jai72l$iao$1@dough.gmane.org' \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.