From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46415)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RamxX-0005d2-7f
	for qemu-devel@nongnu.org; Wed, 14 Dec 2011 06:25:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RamxT-0002Lq-5l
	for qemu-devel@nongnu.org; Wed, 14 Dec 2011 06:25:15 -0500
Received: from lo.gmane.org ([80.91.229.12]:55026)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RamxS-0002L8-Ss
	for qemu-devel@nongnu.org; Wed, 14 Dec 2011 06:25:11 -0500
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RamxQ-0006PG-4j
	for qemu-devel@nongnu.org; Wed, 14 Dec 2011 12:25:08 +0100
Received: from 213.33.220.118 ([213.33.220.118])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Wed, 14 Dec 2011 12:25:08 +0100
Received: from m.kozlov by 213.33.220.118 with local (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Wed, 14 Dec 2011 12:25:08 +0100
From: "Maksim E. Kozlov" <m.kozlov@samsung.com>
Date: Wed, 14 Dec 2011 15:10:21 +0300
Message-ID: <jca0fu$7mc$1@dough.gmane.org>
References: <1323672206-11891-1-git-send-email-e.voevodin@samsung.com>	<1323672206-11891-3-git-send-email-e.voevodin@samsung.com>
	<CAFEAcA_kSShKPpuk+OtER9fQi+ddo7g2EwWqHohn8axTEe0X=w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <CAFEAcA_kSShKPpuk+OtER9fQi+ddo7g2EwWqHohn8axTEe0X=w@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v3 02/14] ARM: exynos4210: CMU support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

>> +
>> +static const VMStateDescription vmstate_exynos4210_cmu = {
>> +        .name = "exynos4210.cmu",
>> +        .version_id = 1,
>> +        .minimum_version_id = 1,
>> +        .minimum_version_id_old = 1,
>> +        .fields = (VMStateField[]) {
>> +        /*
>> +         * TODO: Maybe we should save Exynos4210CmuClockState structs as well
>> +         */
>
> If there's anything in them that can change at runtime (as opposed
> to being statically determined at board init time) then yes, it needs
> to be saved/restored.
>

Should we save globally defined static structures , some fields of which 
can be changed at runtime? If yes, could you recommend a right way to do 
that?