From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756843AbXK0OTh (ORCPT ); Tue, 27 Nov 2007 09:19:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754731AbXK0OTa (ORCPT ); Tue, 27 Nov 2007 09:19:30 -0500 Received: from cantor2.suse.de ([195.135.220.15]:45394 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754562AbXK0OT3 (ORCPT ); Tue, 27 Nov 2007 09:19:29 -0500 From: Andreas Schwab To: Pavel Machek Cc: Thomas Gleixner , kernel list , Ingo Molnar , Andrew Morton Subject: Re: [patch] timer_list should use signed numbers for relative times References: <20071127124405.GA3943@elf.ucw.cz> <20071127140843.GA14570@elf.ucw.cz> X-Yow: I am covered with pure vegetable oil and I am writing a best seller! Date: Tue, 27 Nov 2007 15:19:27 +0100 In-Reply-To: <20071127140843.GA14570@elf.ucw.cz> (Pavel Machek's message of "Tue\, 27 Nov 2007 15\:08\:44 +0100") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Pavel Machek writes: > Hi! > > >> > Relative times are signed by nature, and timers can (briefly) have >> > expires in past. Print them as negative numbers. >> > >> > Signed-off-by: Pavel Machek >> > >> > diff --git a/kernel/time/timer_list.c b/kernel/time/timer_list.c >> > index 12c5f4c..7f6eaa9 100644 >> > --- a/kernel/time/timer_list.c >> > +++ b/kernel/time/timer_list.c >> > @@ -65,7 +65,7 @@ #ifdef CONFIG_TIMER_STATS >> > SEQ_printf(m, ", %s/%d", tmp, timer->start_pid); >> > #endif >> > SEQ_printf(m, "\n"); >> > - SEQ_printf(m, " # expires at %Lu nsecs [in %Lu nsecs]\n", >> > + SEQ_printf(m, " # expires at %Lu nsecs [in %Ld nsecs]\n", >> > (unsigned long long)ktime_to_ns(timer->expires), >> > (unsigned long long)(ktime_to_ns(timer->expires) - now)); >> >> Perhaps change the cast as well. > > Well, that seems to be absolute time, so %Lu makes some sense... I don't understand what this has to do with the cast. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."