From: Andreas Schwab <schwab@suse.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, Bcm43xx-dev@lists.berlios.de,
Michael Buesch <mb@bu3sch.de>
Subject: Re: [PATCH] ieee80211-crypt: Make some TKIP and CCMP error logging conditional on IEEE80211_DEBUG_DROP
Date: Mon, 16 Apr 2007 20:05:10 +0200 [thread overview]
Message-ID: <jeirbwfb55.fsf@sykes.suse.de> (raw)
In-Reply-To: <461a68c9.Nx0/XQSxDR1PJhM4%Larry.Finger@lwfinger.net> (Larry Finger's message of "Mon, 09 Apr 2007 11:24:41 -0500")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> There are messages arising from ieee80211_crypt that spam the logs of
> casual users. These are changed to be logged only if the user specifi=
cally
> requests the IEEE80211_DEBUG_DROP messages. In either case, the error=
/drop count
> is incremented.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> Index: wireless-2.6/net/ieee80211/ieee80211_crypt_tkip.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- wireless-2.6.orig/net/ieee80211/ieee80211_crypt_tkip.c
> +++ wireless-2.6/net/ieee80211/ieee80211_crypt_tkip.c
> @@ -465,7 +465,7 @@ static int ieee80211_tkip_decrypt(struct
> =20
> if (tkip_replay_check(iv32, iv16, tkey->rx_iv32, tkey->rx_iv16)) {
> if (net_ratelimit()) {
> - printk(KERN_DEBUG "TKIP: replay detected: STA=3D" MAC_FMT
> + IEEE80211_DEBUG_DROP("TKIP: replay detected: STA=3D" MAC_FMT
> " previous TSC %08x%04x received TSC "
> "%08x%04x\n", MAC_ARG(hdr->addr2),
> tkey->rx_iv32, tkey->rx_iv16, iv32, iv16);
> @@ -507,7 +507,7 @@ static int ieee80211_tkip_decrypt(struct
> tkey->rx_phase1_done =3D 0;
> }
> if (net_ratelimit()) {
> - printk(KERN_DEBUG "TKIP: ICV error detected: STA=3D"
> + IEEE80211_DEBUG_DROP("TKIP: ICV error detected: STA=3D"
> MAC_FMT "\n", MAC_ARG(hdr->addr2));
> }
> tkey->dot11RSNAStatsTKIPICVErrors++;
> Index: wireless-2.6/net/ieee80211/ieee80211_crypt_ccmp.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- wireless-2.6.orig/net/ieee80211/ieee80211_crypt_ccmp.c
> +++ wireless-2.6/net/ieee80211/ieee80211_crypt_ccmp.c
> @@ -338,7 +338,7 @@ static int ieee80211_ccmp_decrypt(struct
> =20
> if (ccmp_replay_check(pn, key->rx_pn)) {
> if (net_ratelimit()) {
> - printk(KERN_DEBUG "CCMP: replay detected: STA=3D" MAC_FMT
> + IEEE80211_DEBUG_DROP("CCMP: replay detected: STA=3D" MAC_FMT
> " previous PN %02x%02x%02x%02x%02x%02x "
> "received PN %02x%02x%02x%02x%02x%02x\n",
> MAC_ARG(hdr->addr2), MAC_ARG(key->rx_pn),
>
>
This is causing an undefined refrence to ieee80211_debug_level with
CONFIG_IEEE80211_DEBUG=3Dy and CONFIG_IEEE80211_CRYPT_CCMP=3Dm and/or
CONFIG_IEEE80211_CRYPT_TKIP=3Dm.
WARNING: "ieee80211_debug_level" [net/ieee80211/ieee80211_crypt_tkip.ko=
] undefined!
WARNING: "ieee80211_debug_level" [net/ieee80211/ieee80211_crypt_ccmp.ko=
] undefined!
Andreas.
--=20
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany
PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4=
ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-04-16 18:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-09 16:24 [PATCH] ieee80211-crypt: Make some TKIP and CCMP error logging conditional on IEEE80211_DEBUG_DROP Larry Finger
2007-04-16 18:05 ` Andreas Schwab [this message]
2007-04-16 18:50 ` Larry Finger
2007-04-16 20:37 ` Michael Buesch
2007-04-17 0:24 ` Larry Finger
2007-04-17 13:12 ` John W. Linville
2007-04-17 14:25 ` Dan Williams
2007-04-17 15:21 ` John W. Linville
2007-04-17 18:49 ` Dan Williams
2007-04-17 15:41 ` [PATCH] ieee80211-crypt: Make some TKIP and CCMP error loggingconditional " Jouni Malinen
2007-04-17 20:40 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jeirbwfb55.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.