Re: [PATCH] eepro 0.13a

[Andreas Schwab <schwab@suse.de>]

Andi Kleen <ak@suse.de> writes:

|> > @@ -633,37 +633,37 @@
|> >  
|> >  	i = inb(dev->base_addr + ID_REG);
|> >  	printk(KERN_DEBUG " id: %#x ",i);
|> > -	printk(KERN_DEBUG " io: %#x ", (unsigned)dev->base_addr);
|> > +	printk(" io: %#x ", (unsigned)dev->base_addr);
|> >  
|> >  	switch (lp->eepro) {
|> >  		case LAN595FX_10ISA:
|> > -			printk(KERN_INFO "%s: Intel EtherExpress 10 ISA\n at %#x,",
|> > +			printk("%s: Intel EtherExpress 10 ISA\n at %#x,",
|> >  					dev->name, (unsigned)dev->base_addr);
|> 
|> [more cases deleted]
|> 
|> This surely can't be right. Why are you dropping all the KERN_*s ?

Because the previous output is not terminated by a newline, and KERN_*s
are only recognized after newline, not in the middle of a line.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."