From: Andreas Schwab <schwab@suse.de>
To: domen@coderock.org
Cc: Pavel Machek <pavel@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] kernel/power/disk.c string fix and if-less iterator
Date: Tue, 21 Jun 2005 01:42:18 +0200 [thread overview]
Message-ID: <jepsugwq79.fsf@sykes.suse.de> (raw)
In-Reply-To: <20050620221041.GI2222@elf.ucw.cz> (Pavel Machek's message of "Tue, 21 Jun 2005 00:10:41 +0200")
Pavel Machek <pavel@suse.cz> writes:
> Hi!
>
>> The attached patch:
>>
>> o Fixes kernel/power/disk.c string declared as 'char *p = "...";' to be
>> declared as 'char p[] = "...";', as pointed by Jeff Garzik.
'static const char p[] = "...";' would be even better.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2005-06-21 0:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-20 21:57 [patch 2/2] kernel/power/disk.c string fix and if-less iterator domen
2005-06-20 22:10 ` Pavel Machek
2005-06-20 23:42 ` Andreas Schwab [this message]
2005-06-21 7:36 ` Jörn Engel
2005-06-21 9:07 ` Domen Puncer
2005-06-21 15:15 ` Horst von Brand
2005-06-21 7:33 ` Jörn Engel
2005-06-21 12:18 ` Mitchell Blank Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jepsugwq79.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=domen@coderock.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.