From: Andreas Schwab <schwab@suse.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>,
Zou Nan hai <nanhai.zou@intel.com>, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org
Subject: Re: 2.6.17-rc1-mm1
Date: Wed, 05 Apr 2006 21:39:16 +0000 [thread overview]
Message-ID: <jer74b7ldn.fsf@sykes.suse.de> (raw)
In-Reply-To: <20060405211757.GA8536@agluck-lia64.sc.intel.com> (Tony Luck's message of "Wed, 5 Apr 2006 14:17:57 -0700")
"Luck, Tony" <tony.luck@intel.com> writes:
> diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
> index d5a04b6..4ca9877 100644
> --- a/drivers/video/console/vgacon.c
> +++ b/drivers/video/console/vgacon.c
> @@ -484,8 +484,8 @@ #endif
> }
>
> vga_vram_base = VGA_MAP_MEM(vga_vram_base);
> - vga_vram_end = VGA_MAP_MEM(vga_vram_end);
> - vga_vram_size = vga_vram_end - vga_vram_base;
> + vga_vram_end = VGA_MAP_MEM(vga_vram_end - 1);
> + vga_vram_size = vga_vram_end - vga_vram_base + 1;
Better use vga_vram_end = VGA_MAP_MEM(vga_vram_end - 1) + 1, or you'll
screw up the other computations using vga_vram_end.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@suse.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>,
Zou Nan hai <nanhai.zou@intel.com>, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org
Subject: Re: 2.6.17-rc1-mm1
Date: Wed, 05 Apr 2006 23:39:16 +0200 [thread overview]
Message-ID: <jer74b7ldn.fsf@sykes.suse.de> (raw)
In-Reply-To: <20060405211757.GA8536@agluck-lia64.sc.intel.com> (Tony Luck's message of "Wed, 5 Apr 2006 14:17:57 -0700")
"Luck, Tony" <tony.luck@intel.com> writes:
> diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
> index d5a04b6..4ca9877 100644
> --- a/drivers/video/console/vgacon.c
> +++ b/drivers/video/console/vgacon.c
> @@ -484,8 +484,8 @@ #endif
> }
>
> vga_vram_base = VGA_MAP_MEM(vga_vram_base);
> - vga_vram_end = VGA_MAP_MEM(vga_vram_end);
> - vga_vram_size = vga_vram_end - vga_vram_base;
> + vga_vram_end = VGA_MAP_MEM(vga_vram_end - 1);
> + vga_vram_size = vga_vram_end - vga_vram_base + 1;
Better use vga_vram_end = VGA_MAP_MEM(vga_vram_end - 1) + 1, or you'll
screw up the other computations using vga_vram_end.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2006-04-05 21:39 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-04 8:45 2.6.17-rc1-mm1 Andrew Morton
2006-04-04 14:31 ` 2.6.17-rc1-mm1 Kumar Gala
2006-04-04 16:02 ` 2.6.17-mm1: drivers/w1/: patch undoes reasonable cleanups Adrian Bunk
2006-04-04 16:35 ` Evgeniy Polyakov
2006-04-04 16:29 ` 2.6.17-rc1-mm1: KEXEC became SMP-only Adrian Bunk
2006-04-04 17:22 ` Zachary Amsden
2006-04-04 17:50 ` Eric W. Biederman
2006-04-06 22:37 ` Adrian Bunk
2006-04-04 17:43 ` Eric W. Biederman
2006-04-04 17:51 ` Zachary Amsden
2006-04-04 18:43 ` Eric W. Biederman
2006-04-04 19:23 ` Zachary Amsden
2006-04-04 19:38 ` Muli Ben-Yehuda
2006-04-04 20:25 ` Andrew Morton
2006-04-04 22:02 ` Zachary Amsden
2006-04-04 22:19 ` Andrew Morton
2006-04-04 22:34 ` Zachary Amsden
2006-04-04 22:38 ` Andrew Morton
2006-04-05 0:21 ` Martin Bligh
2006-04-05 2:45 ` Eric W. Biederman
2006-04-04 16:29 ` [-mm patch] i386: pre_intr_init_hook optimization Adrian Bunk
2006-04-04 17:16 ` Zachary Amsden
2006-04-04 16:29 ` 2.6.17-rc1-mm1: why did acpi_ns_build_external_path() become global? Adrian Bunk
2006-04-04 16:30 ` [-mm patch] drivers/media/video/bt866.c: small fixes Adrian Bunk
2006-04-04 18:32 ` Martin Samuelsson
2006-04-05 7:42 ` Andrew Morton
2006-04-05 9:02 ` Adrian Bunk
2006-04-05 13:44 ` Martin Samuelsson
2006-04-05 8:32 ` Johannes Stezenbach
2006-04-05 13:54 ` Martin Samuelsson
2006-04-04 16:30 ` [-mm patch] fs/nfsd/nfs4state.c: make a struct static Adrian Bunk
2006-04-04 16:30 ` Adrian Bunk
2006-04-04 16:50 ` [NFS] " J. Bruce Fields
2006-04-04 17:29 ` Adrian Bunk
2006-04-04 20:53 ` 2.6.17-rc1-mm1: mlockall() regression on x86_64 Rafael J. Wysocki
2006-04-04 22:24 ` Andrew Morton
2006-04-04 21:53 ` 2.6.17-rc1-mm1 Zan Lynx
2006-04-04 22:09 ` 2.6.17-rc1-mm1 Andrew Morton
2006-04-05 7:01 ` 2.6.17-rc1-mm1 Roger Luethi
2006-04-05 7:29 ` 2.6.17-rc1-mm1 Andrew Morton
2006-04-05 22:01 ` 2.6.17-rc1-mm1 Roger Luethi
2006-04-04 23:38 ` 2.6.17-rc1-mm1 Luck, Tony
2006-04-04 23:38 ` 2.6.17-rc1-mm1 Luck, Tony
2006-04-05 2:05 ` 2.6.17-rc1-mm1 Zou Nan hai
2006-04-05 2:05 ` 2.6.17-rc1-mm1 Zou Nan hai
2006-04-05 16:15 ` 2.6.17-rc1-mm1 Bjorn Helgaas
2006-04-05 16:15 ` 2.6.17-rc1-mm1 Bjorn Helgaas
2006-04-05 21:17 ` 2.6.17-rc1-mm1 Luck, Tony
2006-04-05 21:17 ` 2.6.17-rc1-mm1 Luck, Tony
2006-04-05 21:37 ` 2.6.17-rc1-mm1 Andrew Morton
2006-04-05 21:37 ` 2.6.17-rc1-mm1 Andrew Morton
2006-04-05 21:39 ` Andreas Schwab [this message]
2006-04-05 21:39 ` 2.6.17-rc1-mm1 Andreas Schwab
2006-04-05 22:01 ` 2.6.17-rc1-mm1 Bjorn Helgaas
2006-04-05 22:01 ` 2.6.17-rc1-mm1 Bjorn Helgaas
2006-04-06 1:49 ` 2.6.17-rc1-mm1 Antonino A. Daplas
2006-04-06 1:49 ` 2.6.17-rc1-mm1 Antonino A. Daplas
2006-04-06 10:21 ` 2.6.17-rc1-mm1 Russell King
2006-04-06 10:21 ` 2.6.17-rc1-mm1 Russell King
2006-04-06 10:34 ` 2.6.17-rc1-mm1 Russell King
2006-04-06 10:34 ` 2.6.17-rc1-mm1 Russell King
2006-04-06 14:55 ` 2.6.17-rc1-mm1 Bjorn Helgaas
2006-04-06 14:55 ` 2.6.17-rc1-mm1 Bjorn Helgaas
2006-04-06 10:16 ` 2.6.17-rc1-mm1 Russell King
2006-04-06 10:16 ` 2.6.17-rc1-mm1 Russell King
2006-04-05 22:50 ` 2.6.17-rc1-mm1 Luck, Tony
2006-04-05 22:50 ` 2.6.17-rc1-mm1 Luck, Tony
2006-04-05 2:27 ` 2.6.17-rc1-mm1, nfsd/reiser4 BUG Zan Lynx
2006-04-07 12:27 ` 2.6.17-rc1-mm1: drivers/acpi/numa.c compile error Adrian Bunk
2006-04-07 20:59 ` Andrew Morton
2006-04-09 15:44 ` Adrian Bunk
2006-04-09 15:57 ` Randy.Dunlap
2006-04-07 20:58 ` 2.6.17-rc1-mm1 - detects buggy TSC on GEODE Jim Cromie
2006-04-08 0:07 ` Andrew Morton
2006-04-08 0:25 ` john stultz
2006-04-08 1:15 ` Jim Cromie
2006-04-13 7:39 ` 2.6.17-rc1-mm1 Heiko Carstens
2006-04-13 8:13 ` 2.6.17-rc1-mm1 Andrew Morton
2006-04-14 16:07 ` 2.6.17-rc1-mm1 Alasdair G Kergon
-- strict thread matches above, loose matches on Subject: below --
2006-04-04 8:45 2.6.17-rc1-mm1 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jer74b7ldn.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nanhai.zou@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.