From: Andreas Schwab <schwab@suse.de>
To: Jesse Barnes <jbarnes@engr.sgi.com>
Cc: Adrian Bunk <bunk@stusta.de>,
akpm@osdl.org, pfg@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gcc4 fix for sn_serial.c
Date: Wed, 27 Apr 2005 00:58:12 +0200 [thread overview]
Message-ID: <jesm1dgn7f.fsf@sykes.suse.de> (raw)
In-Reply-To: <200503150948.03100.jbarnes@engr.sgi.com> (Jesse Barnes's message of "Tue, 15 Mar 2005 09:48:02 -0800")
Jesse Barnes <jbarnes@engr.sgi.com> writes:
> On Monday, March 14, 2005 5:03 pm, Adrian Bunk wrote:
>> > -static struct uart_driver sal_console_uart = {
>> > +struct uart_driver sal_console_uart = {
>> > .owner = THIS_MODULE,
>> > .driver_name = "sn_console",
>> > .dev_name = DEVICE_NAME,
>>
>> Why can't you solve this without making sal_console_uart global?
>
> I think that would mean moving some of the structure initializaiton into an
> init function somewhere.
Just make the tentative definition static.
Signed-off-by: Andreas Schwab <schwab@suse.de>
--- linux-2.6/drivers/serial/sn_console.c.~1~ 2005-04-26 14:42:39.994841943 +0200
+++ linux-2.6/drivers/serial/sn_console.c 2005-04-27 00:50:40.301718840 +0200
@@ -821,7 +821,7 @@ static void __init sn_sal_switch_to_inte
static void sn_sal_console_write(struct console *, const char *, unsigned);
static int __init sn_sal_console_setup(struct console *, char *);
-extern struct uart_driver sal_console_uart;
+static struct uart_driver sal_console_uart;
extern struct tty_driver *uart_console_device(struct console *, int *);
static struct console sal_console = {
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2005-04-26 22:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-14 19:32 [PATCH] gcc4 fix for sn_serial.c Jesse Barnes
2005-03-15 1:03 ` Adrian Bunk
2005-03-15 17:48 ` Jesse Barnes
2005-04-26 22:58 ` Andreas Schwab [this message]
2005-04-26 23:09 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jesm1dgn7f.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=jbarnes@engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pfg@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.