All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: linux-kernel@vger.kernel.org
Subject: LFCR instead of CRLF on serial console
Date: 29 Nov 2001 22:57:06 +0100	[thread overview]
Message-ID: <jezo55utot.fsf@sykes.suse.de> (raw)

The serial console code is printing LFCR at the end of the line instead of
CRLF.  While this makes no difference on a terminal(-emulator), most
editors and file viewers (including less) only recognize CRLF as DOS-style
end-of-line markers.

--- linux/drivers/char/serial.c	2001/11/16 14:23:08	1.1
+++ linux/drivers/char/serial.c	2001/11/16 14:23:35
@@ -5812,11 +5812,11 @@
 		 *	Send the character out.
 		 *	If a LF, also do CR...
 		 */
-		serial_out(info, UART_TX, *s);
 		if (*s == 10) {
-			wait_for_xmitr(info);
 			serial_out(info, UART_TX, 13);
+			wait_for_xmitr(info);
 		}
+		serial_out(info, UART_TX, *s);
 	}
 
 	/*

Andreas.

-- 
Andreas Schwab                                  "And now for something
Andreas.Schwab@suse.de				completely different."
SuSE Labs, SuSE GmbH, Schanzäckerstr. 10, D-90443 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5

                 reply	other threads:[~2001-11-29 21:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jezo55utot.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.